Arvados

21317-toolbar-overflow @ 5461466dc71b7206716cb4eededd86ed7d2fec69

developer-run-tests-services-workbench2: #148 /console

• ✅ All agreed upon points are implemented / addressed.
• ✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
• ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
  • tested at every reasonable viewport width
• ✅ Documentation has been updated.
  • n/a
• ✅ Behaves appropriately at the intended scale (describe intended scale).
• ✅ Considered backwards and forwards compatibility issues between client and server.
• ✅ Follows our coding standards and GUI style guidelines.

Lisa Knox wrote in #note-5:

21317-toolbar-overflow @ 5461466dc71b7206716cb4eededd86ed7d2fec69

developer-run-tests-services-workbench2: #148 /console

• ✅ All agreed upon points are implemented / addressed.
• ✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
• ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
  • tested at every reasonable viewport width
• ✅ Documentation has been updated.
  • n/a
• ✅ Behaves appropriately at the intended scale (describe intended scale).
• ✅ Considered backwards and forwards compatibility issues between client and server.
• ✅ Follows our coding standards and GUI style guidelines.

This looks really good, the only quirky behavior I noticed is that when it begins to collapse, it will take the rightmost item and move it to the menu and replace it with the >> icon, but since there is only one item in the menu, no horizontal space has actually been saved.

How hard would it be to adjust it so that it doesn't switch to the pop-up menu until the menu would contain at least two overflow items?

The rest LGTM.

21317-toolbar-overflow @ 8b2f1ec23328ac69a0d1f538acb3868f1e286031

Overflow menu no longer appears until at least 2 buttons are obscured by other DOM elements.

I'm going to show you at standup but there's a couple issues with the switch point where it enables/disables the collapse menu.

Tested on Firefox.

• When collapsing, you can shrink the window to a point where the search box is clipping about half of the rightmost icon before it switches to the collapse menu. It should be switching to the collapse menu before the rightmost icon intersects with the search box.
• When restoring, the point where it restores the last two icons is significantly further to the right than the point where it initially collapses. The point where it switches between collapsed/fully displayed should be the same.

• When collapsing, you can shrink the window to a point where the search box is clipping about half of the rightmost icon before it switches to the collapse menu. It should be switching to the collapse menu before the rightmost icon intersects with the search box.

• icon no longer clips, it's either fully visible or the overflow menu is in place

• When restoring, the point where it restores the last two icons is significantly further to the right than the point where it initially collapses. The point where it switches between collapsed/fully displayed should be the same.

• the two changes (collapse and restoration) now happen at nearly the same point.

Lisa Knox wrote in #note-10:

• When collapsing, you can shrink the window to a point where the search box is clipping about half of the rightmost icon before it switches to the collapse menu. It should be switching to the collapse menu before the rightmost icon intersects with the search box.

• icon no longer clips, it's either fully visible or the overflow menu is in place

• When restoring, the point where it restores the last two icons is significantly further to the right than the point where it initially collapses. The point where it switches between collapsed/fully displayed should be the same.

• the two changes (collapse and restoration) now happen at nearly the same point.

This LGTM