Bug #21366
closed
Outputs panel spinning forever when CWL output parameters are not available
Description
Regression observed on customer cluster that was just upgraded to 2.7.1, the process "outputs" panel spins forever when viewing outputs for a process that does not have CWL output parameters available (in that case, it is supposed to show a file browser).
This seem trivially reproducible, it is broken on every page I've tried that ought to show a file browser with output files.
https://workbench.tordo.arvadosapi.com/processes/tordo-xvhdp-qxdm0vp1b9lfbfc
Files
Updated by Stephen Smith 11 months ago
- Status changed from New to In Progress
Changes at arvados|e136acc6897312f1b82e47fe038aba806855988c branch 21366-subprocess-output-loading-bug
Tests developer-run-tests-services-workbench2: #150
- All agreed upon points are implemented / addressed.
- Changed loading indicator for subprocess to not trigger spinner if input mounts or output collection uuid is present
- Changed behavior to hide raw tab on subprocesses if empty - avoids crashing when raw param is undefined
- Changed separate conditionals to a chained ternary to avoid bug where loading indicator and empty default view could show at the same time
- Anything not implemented (discovered or discussed during work) has a follow-up story.
- n/a
- Code is tested and passing, both automated and manual, what manual testing was done is described
- Added unit tests to verify loading indicator behaves correctly and to make sure the spinner is removed when mounts or output collection uuid is present on subprocesses even when the params appear unloaded.
- Documentation has been updated.
- n/a
- Behaves appropriately at the intended scale (describe intended scale).
- no change in scale
- Considered backwards and forwards compatibility issues between client and server.
- n/a
- Follows our coding standards and GUI style guidelines.
- n/a
Updated by Peter Amstutz 11 months ago
- Target version changed from Development 2024-01-17 sprint to Development 2024-01-31 sprint
Updated by Peter Amstutz 11 months ago
It's not spinning any more so that's good.
The Outputs panel is missing the "JSON" tab, though. The cwl_output property is available so it is a bug that the tab is missing?
Updated by Stephen Smith 11 months ago
Changes at arvados|37f7559e8d9a4df3515d78663b65b9220550457f
Tests developer-run-tests-services-workbench2: #424
- Reverted the logic change back to displaying empty raw/JSON tab but still guarding against undefined raw which crashes the UI.
Updated by Peter Amstutz 11 months ago
- File Screenshot from 2024-01-23 13-19-03.png Screenshot from 2024-01-23 13-19-03.png added
- File Screenshot from 2024-01-23 13-19-16.png Screenshot from 2024-01-23 13-19-16.png added
See attached screenshots
On 37f7559e8d9a4df3515d78663b65b9220550457f it still isn't showing the JSON tab on output, despite cwl_output being defined?
Updated by Stephen Smith 11 months ago
Changes at arvados|0328407f7cfeba197b5061478869beaf494691de
Tests: developer-run-tests-services-workbench2: #428
- Fixed a bug where the set output data reducer's param was typed to any, and several uses were passing in the wrong type.
Updated by Peter Amstutz 11 months ago
Stephen Smith wrote in #note-9:
Changes at arvados|0328407f7cfeba197b5061478869beaf494691de
Tests: developer-run-tests-services-workbench2: #428
- Fixed a bug where the set output data reducer's param was typed to any, and several uses were passing in the wrong type.
This LGTM, thanks
Updated by Stephen Smith 11 months ago
- Status changed from In Progress to Resolved
Updated by Peter Amstutz 9 months ago
- Has duplicate Bug #21577: Stuck loading ouput on subprocesses added