Bug #21427: Collection panel test "shows the appropriate buttons in the toolbar" is failing on main - Arvados

Actions

Copy link

Bug #21427

closed

Collection panel test "shows the appropriate buttons in the toolbar" is failing on main

Added by Brett Smith 3 months ago. Updated 3 months ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Lisa Knox

Category:

Workbench2

Target version:

Development 2024-02-14 sprint

Story points:

Release:

Arvados 2.7.2

Release relationship:

Auto

Description

  1) Collection panel tests
       shows the appropriate buttons in the toolbar:
     CypressError: Timed out retrying after 4000ms: `cy.trigger()` failed because this element is not visible:

`<button class="MuiButtonBase-root-561 MuiIconButton-root-555 Component-icon-1117" tabindex="0" type="button" data-cy="multiselect-button">...</button>`

This element `<button.MuiButtonBase-root-561.MuiIconButton-root-555.Component-icon-1117>` is not visible because its parent `<span.Component-button-1115.Component-inVisible-1195.Component-iconContainer-1116>` has CSS property: `visibility: hidden`

Fix this problem, or use `{force: true}` to disable error checking.

Files

developer-run-tests-services-workbench2-430.log (397 KB) developer-run-tests-services-workbench2-430.log

Brett Smith, 01/29/2024 03:04 PM

Subtasks 1 (0 open — 1 closed)

Related issues

Actions

Copy link

Updated by Brett Smith 3 months ago

Related to Bug #21317: multiselect toolbar overfow should go to dropdown menu instead of scrolling added

Actions

Copy link

Updated by Lisa Knox 3 months ago

Assigned To set to Lisa Knox
Status changed from New to In Progress

Actions

Copy link

Updated by Lisa Knox 3 months ago

developer-run-tests-services-workbench2: #433

21427-collection-test-fix @ 5ed93b80f41c2d30d947dee4315e6a04b191b2d5

✅ All agreed upon points are implemented / addressed.
✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
✅ Code is tested and passing, both automated and manual, what manual testing was done is described
- the collection test passes as per the stated intent of this ticket, other tests are still failing
✅ Documentation has been updated.
✅ Behaves appropriately at the intended scale (describe intended scale).
✅ Considered backwards and forwards compatibility issues between client and server.
✅ Follows our coding standards and GUI style guidelines.

Notes:

collection tests pass, other tests still failing as expected

Actions

Copy link

Updated by Peter Amstutz 3 months ago

Target version changed from To be scheduled to Development 2024-02-14 sprint

Actions

Copy link

Updated by Lisa Knox 3 months ago

developer-run-tests-services-workbench2: #445

21427-collection-test-fix @ c2a865cb5c270bc1d4ce021d9d0cf3dd6ea1871c

✅ All agreed upon points are implemented / addressed.
✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
✅ Code is tested and passing, both automated and manual, what manual testing was done is described
✅ Documentation has been updated.
✅ Behaves appropriately at the intended scale (describe intended scale).
✅ Considered backwards and forwards compatibility issues between client and server.
✅ Follows our coding standards and GUI style guidelines.

Actions

Copy link

Updated by Peter Amstutz 3 months ago

This LGTM

I did notice this in one of the tests, I don't want to hold up this branch but it did jump out at me:

cy.get('[data-cy=data-table-row]').contains(name).should('exist').parent().parent().parent().parent().click()

This .parent().parent().parent().parent() part seems a little brittle, an otherwise invisible layout change to add or removes a layer of DOM nesting might not click on the correct element any more?

Actions

Copy link