Project

General

Profile

Actions

Bug #21429

closed

ensure-encrypted-partitions should remember and restore Docker service state

Added by Brett Smith 9 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Deployment
Story points:
0.5
Release relationship:
Auto

Description

ensure-encrypted-partitions wants to encrypt partitions used by Docker. Therefore, it stops Docker before encryption, then starts it again after encryption.

It would be nicer if it first checked whether Docker was running, then only messed with the service when it was. This would make the script's behavior less surprising in situations where we need to coordinate with other deployment scripts.


Subtasks 1 (0 open1 closed)

Task #21430: Review 21429-remember-docker-stateResolvedBrett Smith01/30/2024Actions
Actions #1

Updated by Brett Smith 9 months ago

  • Status changed from New to In Progress

21429-remember-docker-state @ 831a23e99ef489047bd8c93b9f0be4bb3e889268

  • All agreed upon points are implemented / addressed.
    • Yes
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • N/A
  • Code is tested and passing, both automated and manual, what manual testing was done is described
    • No testing done given the nature of the scripts
  • Documentation has been updated.
    • N/A
  • Behaves appropriately at the intended scale (describe intended scale).
    • No scale change
  • Considered backwards and forwards compatibility issues between client and server.
    • It's possible there are existing deployments that were relying on this implicit start behavior. They will need to be updated to explicitly start Docker elsewhere.
  • Follows our coding standards and GUI style guidelines.
    • Yes
Actions #2

Updated by Lucas Di Pentima 9 months ago

This LGTM, thanks!

Actions #3

Updated by Brett Smith 9 months ago

  • Status changed from In Progress to Resolved
Actions #4

Updated by Peter Amstutz 9 months ago

  • Release set to 69
Actions

Also available in: Atom PDF