Arvados

Some of this work is happening in #21224 so I'm putting in on the sprint to reflect the actual work being done.

21448-menu-reorder @ commit: 857687c280c2a84152de6e8df840d0bcf1282bcf

developer-run-tests-services-workbench2: #654

• ✅ All agreed upon points are implemented / addressed.
  • "Share" button removed from processes
  • "Copy to clipboard" changed to "Copy ink to clipboard" in all menus
• ✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
  • "Edit process" kept as-is per discussion
  • "Move to" removed for processes and workflows
  • "Outputs" kept with a follow-up: https://dev.arvados.org/issues/21642
• ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
  • Manually tested by opening menus in a variety of places and trying all menu options
• ✅ Documentation has been updated.
  n/a
• ✅ Behaves appropriately at the intended scale (describe intended scale).
  n/a
• ✅ Considered backwards and forwards compatibility issues between client and server.
  n/a
• ✅ Follows our coding standards and GUI style guidelines.

• instead of the master order list, I opted for individual orderings that can be set declaratively in menu-item-sort.ts, including setting where the list dividers appear. Any resource that does not have an order currently defaults to alphabetical, but that can be easily changed. This allows for super-easy changes and menu customization in the future, if we choose to pursue that.

• I also took the opportunity to change all menu "name" fields from hardcoded strings to constants. Previously, these fields only had one use so it didn't matter, but now they are used and referenced in several places so they need to be type safe

This is really good, couple notes:

• Based on feedback, let' have "Share" always be the first item in the 2nd group.
• If you select a single collection, the icons on the second group are [Move, Copy, Trash] but if you select two collections the order changes to [Copy, Move, Trash]. It should be [Copy, Move, Trash] both places for consistency.
• There's a little bit of a flicker when the toolbar appears. I'd prefer it show up all at once.
• When the menu overflows, the vertical dividers seem to display whether or not there are items to separate, they are displayed as vertical in the menu, and also become clickable (but they don't do anything). Ideally these should render properly, but if that's complicated I think I'd be okay if the separators just don't show up in the overflow menu.

developer-run-tests-services-workbench2: #670

21448-menu-reorder @ commit: 6e82c6703a8caabcf5ed96b7bd0338e60a2b6619

Based on feedback, let' have "Share" always be the first item in the 2nd group.

done

If you select a single collection, the icons on the second group...

Added a default sort order for when more than one items are selected. This will have to change if/when we expand multiselect functionality.

There's a little bit of a flicker when the toolbar appears...

There was a css width transition originally, now removed.

When the menu overflows, the vertical dividers seem...

I fixed the display of non-overflowed dividers and opted to just remove dividers from the overflow menu itself.

Lisa Knox wrote in #note-14:

There's a little bit of a flicker when the toolbar appears...

There was a css width transition originally, now removed.

I still see a brief flicker to blank when selecting a different kind of thing that has different toolbar items, but it is less distracting than the transition before.

LGTM

Also I noticed issues with toolbar/multi-select in the Groups panel and added a follow-up ticket: #21648