Arvados

developer-run-tests-services-workbench2: #582

21600-banner-tests @ a6f2e4ea0bf519125271141c154df7e0a245b082

• ✅ All agreed upon points are implemented / addressed.
• ✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
• ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
• ✅ Documentation has been updated.
• ✅ Behaves appropriately at the intended scale (describe intended scale).
• ✅ Considered backwards and forwards compatibility issues between client and server.
• ✅ Follows our coding standards and GUI style guidelines.

• I was unable to reproduce the issue locally. I introduced a 1-second sleep in the part of the test that was failing because the normal waitForDom() method wasn't working. The delay passed Jenkins tests 5 times in a row. Recommend merging this fix to clear up the build path and doing more research.

developer-run-tests-services-workbench2: #627

21600-banner-tests @ be3378300d63ce537a5843c5fc23ecd76f4f1f5c

• ✅ All agreed upon points are implemented / addressed.
• ✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
• ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
• ✅ Documentation has been updated.
• ✅ Behaves appropriately at the intended scale (describe intended scale).
• ✅ Considered backwards and forwards compatibility issues between client and server.
• ✅ Follows our coding standards and GUI style guidelines.

Just in case it's useful, I've made some improvements on this test suite at 21600-wb2-flaky-banner-tests
Test run: developer-run-tests-services-workbench2: #628

developer-run-tests-services-workbench2: #630

21600-banner-tests @ aee2fb2b736a714d3c8dc5b4624bff3fae8d7ba4

• Incorporated changes from Lucas to fix the tooltip tests, which were passing but still janky in the previous commit.