Arvados

Changes at arvados|a72bfc2cc90e0155ac7ea7ea9aa21390d2c18c19
Tests developer-run-tests-services-workbench2: #755

• All agreed upon points are implemented / addressed.
  • Fixed the non-working collection tab by creating a new conditional tab component, this lets us abstract away the conditional rendering and prevents errors in constructing complex conditions for rendering tab contents when the tab position can change - it's more robust because the abstracted implementation keeps the tab set in an array and filters out non-visible tabs before conditionally rendering only the selected tab contents, eliminating the possibility of misaligned selected and rendered tab
  • The top level process seems to correctly show the collection tab on outputs panel, so I assume the issue was just that outputUuid was missing on some processes. Nevertheless, I added a unit test to make sure top level processes show the outputs tab when outputUuid is available.
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • n/a
• Code is tested and passing, both automated and manual, what manual testing was done is described
  • manually checked fix on steps, verified collection tab on main process outputs
  • Added tests to check conditional tabs and main process outputs
• Documentation has been updated.
  • n/a
• Behaves appropriately at the intended scale (describe intended scale).
  • n/a
• Considered backwards and forwards compatibility issues between client and server.
  • n/a
• Follows our coding standards and GUI style guidelines.
  • no changes

The only real issue I see is that the fetch for the collection tab happens when clicking the collection tab. This makes the highlight-slider-thing chug as it transfers from one tab to another. If you click back and forth between tabs, the same data is re-fetched every time. I'm not sure how viable eager loading is in this situation (I imagine the amount of data in the collection tab is conceivably huge), but it would prevent the chug. We should at least be storing the fetched data in redux so we're not making the same fetch twice.

Changes at arvados|b7e59d3a314347e3ede2a683294a466b05ca5c90
Tests developer-run-tests-services-workbench2: #775

So instead of going down the path of caching the results in the store which would then require managing clearing out that data I decided to make it so that switching tabs doesn't un-render any content but just hides it - that way all tabs are rendered all the time (which, between the virtual list and data explorer with capped page size, shouldn't be too much of a performance impact, as loading the data explorer is a single request), and switching tabs won't cause the collections tab to re-render. It also means that the collections tab will already be loaded when the user switches to it.

This looks great, a creative solution. LGTM!