Project

General

Profile

Actions

Bug #21692

closed

Exclude .build-id from rpm builds

Added by Peter Amstutz 17 days ago. Updated 10 days ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Deployment
Story points:
-


Subtasks 1 (0 open1 closed)

Task #21694: Review 21692-go-packages-no-build-idResolvedBrett Smith04/16/2024Actions
Actions #1

Updated by Peter Amstutz 17 days ago

  • Description updated (diff)
Actions #2

Updated by Brett Smith 17 days ago

  • Assigned To set to Brett Smith
  • Status changed from New to In Progress
Actions #3

Updated by Brett Smith 17 days ago

21692-go-packages-no-build-id @ d35808f8df98545d42b692e25343636a86de4a57 - build-packages-rocky8: #476

  • All agreed upon points are implemented / addressed.
    • I exclude build ids from Go binary builds. Since we only have to worry about this when we package something in /usr/bin that conflicts with another package's file, this is the only place it's really necessary, and a new test confirms that, see below.
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • N/A
  • Code is tested and passing, both automated and manual, what manual testing was done is described
    • See build above. Added a quick test to rpm-common-test-packages.sh and confirmed it ran in the Jenkins log. Also hand-checked a few built packages to confirm they no longer include build ids.
  • Documentation has been updated.
    • I don't think there's anything to cover in the arvados repo. Might be in the release notes or similar announcements.
  • Behaves appropriately at the intended scale (describe intended scale).
    • No change in scale
  • Considered backwards and forwards compatibility issues between client and server.
    • N/A
  • Follows our coding standards and GUI style guidelines.
    • N/A (we have no shell style)
Actions #4

Updated by Tom Clegg 14 days ago

21692-go-packages-no-build-id LGTM.

Actions #5

Updated by Brett Smith 11 days ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF