Bug #21692
closed
- Description updated (diff)
- Assigned To set to Brett Smith
- Status changed from New to In Progress
21692-go-packages-no-build-id @ d35808f8df98545d42b692e25343636a86de4a57 - build-packages-rocky8: #476
- All agreed upon points are implemented / addressed.
- I exclude build ids from Go binary builds. Since we only have to worry about this when we package something in
/usr/bin
that conflicts with another package's file, this is the only place it's really necessary, and a new test confirms that, see below.
- Anything not implemented (discovered or discussed during work) has a follow-up story.
- Code is tested and passing, both automated and manual, what manual testing was done is described
- See build above. Added a quick test to
rpm-common-test-packages.sh
and confirmed it ran in the Jenkins log. Also hand-checked a few built packages to confirm they no longer include build ids.
- Documentation has been updated.
- I don't think there's anything to cover in the arvados repo. Might be in the release notes or similar announcements.
- Behaves appropriately at the intended scale (describe intended scale).
- Considered backwards and forwards compatibility issues between client and server.
- Follows our coding standards and GUI style guidelines.
- N/A (we have no shell style)
21692-go-packages-no-build-id LGTM.
- Status changed from In Progress to Resolved
Also available in: Atom
PDF