Arvados

21717-keepstore-cors @ d9592ca6a1a9da3adb5c7a5b8201765dad3af93b -- developer-run-tests: #4189

• All agreed upon points are implemented / addressed.
  • ✅
  • also support pre-flight requests for PUT (write block), POST (update trash lists, etc), because why not
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • TBD: if we want to release this with a future 2.x, we'll need a separate branch -- this won't cherry-pick across the #2960 keepstore refactor.
• Code is tested and passing, both automated and manual, what manual testing was done is described
  • automated tests only.
• Documentation has been updated.
  • N/A. Our docs treat keepstore interfaces as an internal implementation detail. Or is there somewhere this should be noted?
• Behaves appropriately at the intended scale (describe intended scale).
  • N/A
• Considered backwards and forwards compatibility issues between client and server.
  • N/A
• Follows our coding standards and GUI style guidelines.
  • ✅

Looks good to me, but question about this:

-       replicas, _ := strconv.Atoi(req.Header.Get("X-Arvados-Replicas-Desired"))
+       replicas, _ := strconv.Atoi(req.Header.Get("X-Arvados-Desired-Replicas"))

Am I right this is an unrelated bugfix? That's totally fine, especially given how simple it is, the reason I'm flagging it is because we tend to overlook stuff like this in the release notes. It would be nice to discuss and figure out a way to prevent that.

Thanks.

Brett Smith wrote in #note-6:

Am I right this is an unrelated bugfix?

Yes. The bug was introduced in #2960 and hasn't been in any released version.

But the best part is that it's a broken fix. The real header is X-Keep-... not X-Arvados-... ... which is why I didn't find it when changing the other occurrences of "X-Keep-..." to keepclient.XKeep... consts.

Fixed:

21717-keepstore-cors @ 293631794d64c64986ba0db2568345c005c90790 -- developer-run-tests: #4196