Arvados

developer-run-tests-services-workbench2: #886

21765-short-dialog @ 5feb6a30dbbabbb45ebb4be27a5af54836781cb4

• ✅ All agreed upon points are implemented / addressed.
• n/a Anything not implemented (discovered or discussed during work) has a follow-up story.
• ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
• n/a Documentation has been updated.
• ✅ Behaves appropriately at the intended scale (describe intended scale).
  scale unchanged
• n/a Considered backwards and forwards compatibility issues between client and server.
• ✅ Follows our coding standards and GUI style guidelines.

• I took the opportunity to fix the scrolling everywhere the project picker is used. Previously, scrolling the project picker would scroll everything except the dialog title. Now, only the project tree scrolls.

Lisa Knox wrote in #note-5:

developer-run-tests-services-workbench2: #886

21765-short-dialog @ 5feb6a30dbbabbb45ebb4be27a5af54836781cb4

• ✅ All agreed upon points are implemented / addressed.
• n/a Anything not implemented (discovered or discussed during work) has a follow-up story.
• ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
• n/a Documentation has been updated.
• ✅ Behaves appropriately at the intended scale (describe intended scale).
  scale unchanged
• n/a Considered backwards and forwards compatibility issues between client and server.
• ✅ Follows our coding standards and GUI style guidelines.

Notes:

• I took the opportunity to fix the scrolling everywhere the project picker is used. Previously, scrolling the project picker would scroll everything except the dialog title. Now, only the project tree scrolls.

This LGTM