Project

General

Profile

Actions
Copy link

Bug #21766

closed

Keep-web local disk cache size does not respect configuration

Added by Tom Clegg 9 months ago. Updated 9 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Tom Clegg
Category:
-
Target version:
Development 2024-05-22 sprint
Story points:
-
Release:
Arvados 3.0
Release relationship:
Auto

Description

Configured disk cache size does not respect configuration entry due to two bugs:
  1. Configured value does not get propagated from the loaded config to the disk cache code
  2. Percentage values (including the default 10%) are computed as x% of free space, instead of x% of total filesystem size as intended

Additionally, the DiskCache logging is not connected when initialized by keepclient, so even with SystemLogs.LogLevel: debug the existing debugf() logs do not appear. We should fix this too.

Subtasks 1 (0 open — 1 closed)

Task #21772: Review 21766-disk-cache-sizeResolvedTom Clegg05/14/2024Actions
Actions
Copy link
 #1

Updated by Tom Clegg 9 months ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Tom Clegg 9 months ago

21766-disk-cache-size @ 5208605890afc290d28d43cf6c4ebf88f989ba47 -- developer-run-tests: #4215

  • abad6e6fb7 21766: Enable keepclient debug logging in keep-web.
  • 7b2e98f388 21766: Fix WebDAVCache.DiskCacheSize config being ignored.
  • f15670e518 21766: Fix disk cache size percentage calculation.
Actions
Copy link
 #3

Updated by Lucas Di Pentima 9 months ago

This LGTM, thanks!

Actions
Copy link
 #4

Updated by Tom Clegg 9 months ago

  • Status changed from In Progress to Resolved
Actions
Copy link

Also available in: Atom PDF