Arvados

developer-run-tests-services-workbench2: #1031

21898-info-button-behavior @ 54aa93a819ab36abcdbe69cb2ad5259a105f5bc9

• ✅ All agreed upon points are implemented / addressed.
• ✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
• ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
• ✅ Documentation has been updated.
  - NA
• ✅ Behaves appropriately at the intended scale (describe intended scale).
• ✅ Considered backwards and forwards compatibility issues between client and server.
  - NA
• ✅ Follows our coding standards and GUI style guidelines.

• We should probably talk about unifying and simplifying the context/multiselect actions implementation. To change the functionality of the info button, I had to make the exact same exact change in 9 different places. I think it would be pretty straightforward to align all of these things so we don't have repeated code and make bugs easier to avoid. That said, it's not actually broken right now so it doesn't necessarily need fixing.

Lisa Knox wrote in #note-10:

developer-run-tests-services-workbench2: #1031

21898-info-button-behavior @ 54aa93a819ab36abcdbe69cb2ad5259a105f5bc9

• ✅ All agreed upon points are implemented / addressed.
• ✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
• ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
• ✅ Documentation has been updated.
  - NA
• ✅ Behaves appropriately at the intended scale (describe intended scale).
• ✅ Considered backwards and forwards compatibility issues between client and server.
  - NA
• ✅ Follows our coding standards and GUI style guidelines.

This LGTM.

Notes:

• We should probably talk about unifying and simplifying the context/multiselect actions implementation. To change the functionality of the info button, I had to make the exact same exact change in 9 different places. I think it would be pretty straightforward to align all of these things so we don't have repeated code and make bugs easier to avoid. That said, it's not actually broken right now so it doesn't necessarily need fixing.

Yea, it would benefit from being refactored a bit. To be honest I'm never quite sure how to best to reduce code duplication in workbench 2, the architecture is such that things are split up by component in a way that tend to encourage duplication so that styling/behavior can be easily customized for each component, but it leads to a certain amount of redundancy like this. For toolbars/context menu actions I agree they should be aligned so that every action is the same in whatever context it appears.

As I was going through this I did notice one toolbar that needs a little work (the subprocess list, also used on the workflow description page)

https://dev.arvados.org/issues/22042