Idea #21905
closed
Transition away from RVM
Added by Lucas Di Pentima 5 months ago. Updated 17 days ago.
Description
Currently, the salt installer uses RVM on certain cases: CentOS 7, Debian 10 & Ubuntu 18.04
Make sure there are no interfaces or documented support.
These distros aren't supported anymore, so we should remove the pillars & states related to RVM and those distros, and probably also make the installer immediately fail on non-supported distros as well, to avoid any accidental breakage on preexisting clusters using RVM.
Should also have a plan to transition any clusters that use RVM to distro packages.
Related issues
Updated by Lucas Di Pentima 5 months ago
- Related to Idea #21522: Stop using RVM in package-build-dockerfiles added
Updated by Peter Amstutz 5 months ago
- Target version changed from Development 2024-07-03 sprint to Development 2024-07-24 sprint
Updated by Peter Amstutz 5 months ago
- Description updated (diff)
- Subject changed from Installer doesn't support RVM anymore to Transition away from RVM
- Tracker changed from Bug to Idea
Updated by Peter Amstutz 5 months ago
- Assigned To set to Lucas Di Pentima
- Subject changed from Transition away from RVM to Transition away from RVM
Updated by Peter Amstutz 4 months ago
- Target version changed from Development 2024-07-24 sprint to Development 2024-08-07 sprint
Updated by Peter Amstutz 4 months ago
- Target version changed from Development 2024-08-07 sprint to Development 2024-08-28 sprint
Updated by Peter Amstutz 3 months ago
- Target version changed from Development 2024-08-28 sprint to Development 2024-09-11 sprint
Updated by Peter Amstutz 3 months ago
- Target version changed from Development 2024-09-11 sprint to Development 2024-09-25 sprint
Updated by Peter Amstutz 2 months ago
- Target version changed from Development 2024-09-25 sprint to Development 2024-10-09 sprint
Updated by Peter Amstutz about 2 months ago
- Target version changed from Development 2024-10-09 sprint to Development 2024-10-23 sprint
Updated by Peter Amstutz about 1 month ago
- Assigned To changed from Lucas Di Pentima to Brett Smith
- Description updated (diff)
Updated by Brett Smith about 1 month ago
21905-no-rvm-salt @ e1b3a31289d641d3835c439d01df235d66c84a08 - test-provision: #993
It turns out there basically are no "interfaces" to update. The Salt installer doesn't really ask the user whether or not to use RVM; it picks that based on the distribution in use. And all the distros that needed RVM are no longer supported in Arvados 3.0. So in the end this did turn into a code cleanup branch. But it was pretty easy so no big deal.
- All agreed upon points are implemented / addressed.
- Yes
- Anything not implemented (discovered or discussed during work) has a follow-up story.
- Note our configs still contain a file named
states/passenger_rvm.sls, but that does other Passenger configuration besides just RVM integration. A better name might be nice but I decided to leave it alone for this ticket since we're aiming to keep the scope of this one small. We can make a follow-up ticket if it's important.
- Note our configs still contain a file named
- Code is tested and passing, both automated and manual, what manual testing was done is described
- Just the automated test, see above
- Documentation has been updated.
- Confirmed there is no need to update documentation with
git grep -i rvm '*.html' '*.textile' '*.liquid'in thedoc/directory. The only page that mentions it now is the upgrade notes.
- Confirmed there is no need to update documentation with
- Behaves appropriately at the intended scale (describe intended scale).
- No change in scale
- Considered backwards and forwards compatibility issues between client and server.
- This doesn't make any compatibility change relative to other changes we've already made (dropping older distributions and RVM support in our packaging)
- Follows our coding standards and GUI style guidelines.
- N/A (no Salt style guide)
Updated by Brett Smith about 1 month ago
- Status changed from New to In Progress
Updated by Lucas Di Pentima about 1 month ago
- Changes LGTM
- There's one detail that might need some tweaking: In arvados-formula, the
use_rvmpillar data default tofalsebut get set totrueon RedHat-type distros (See:arvados-formula/arvados/osfamilymap.yaml). I think we should remove that default and make the installer use the new formula version to avoid issues. Another option would be to setuse_rvmtofalseon the installer'sarvados.slspillar.
Updated by Brett Smith about 1 month ago
Lucas Di Pentima wrote in #note-15:
- There's one detail that might need some tweaking: In arvados-formula, the
use_rvmpillar data default tofalsebut get set totrueon RedHat-type distros (See:arvados-formula/arvados/osfamilymap.yaml). I think we should remove that default and make the installer use the new formula version to avoid issues. Another option would be to setuse_rvmtofalseon the installer'sarvados.slspillar.
arvados-formula branch 21905-no-rvm @ 9a6830ab0d5e36411af10306243d6410a18ed3f7 - test-provision: #998
Updated by Brett Smith about 1 month ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|b780383e24d0fc28ab1f8c058b2d76439da9c8b4.