Bug #21906
closed
Seemingly duplicate Gem directories after installing arvados-api-server
Description
On a fresh install, after the postinst script runs, there are two subdirectories under /var/www/arvados-api-server/shared/vendor_bundle/ruby:
- one for the full Ruby version
M.N.P - one for just the "minor" version
M.N.0
In #21700 we added some code to manually install gems with gem install to work around a Bundler bug. This makes it look like that code has its own bug: gem is supposed to be installing gems in the same directory where Bundler will work, but isn't quite successful.
Hopefully this is just a matter of changing the target directory. Investigate, add a test, fix.
Related issues
Updated by Brett Smith 15 days ago
- Related to Support #21700: Remove RVM support from our build process and packages added
Updated by Brett Smith 15 days ago
21906-api-gems-dir @ c82898fcdbf6f3cd6b47421e24d3b71a7582e1dc - build-packages-multijob: #4248
This adds a test for the bug. Then it fixes the bug. The test also revealed that the postinst script would crash on Red Hat distros if a web server was not installed. So the branch goes on to add more handling and reporting for that case to make it more user-friendly.
- All agreed upon points are implemented / addressed.
- And then some, see above
- Anything not implemented (discovered or discussed during work) has a follow-up story.
- N/A
- Code is tested and passing, both automated and manual, what manual testing was done is described
- Added a test for this case and confirmed that it caught the bug in build-packages-multijob: #4239
. Manually reviewed the latest console output to confirm the new reporting looked as expected.
- Added a test for this case and confirmed that it caught the bug in build-packages-multijob: #4239
- Documentation has been updated.
- N/A, internal build change
- Behaves appropriately at the intended scale (describe intended scale).
- Improves scale by deduplicating gem installs
- Considered backwards and forwards compatibility issues between client and server.
- The bug being fixed has never been in a release so there are no compatibility issues
- Follows our coding standards and GUI style guidelines.
- N/A (no coding standards for shell)
Updated by Tom Clegg 14 days ago
typo "documentaion" in source:build/rails-package-scripts/postinst.sh
Other than that, LGTM, thanks.