Arvados

Background

The api_clients table and api_client_id field were originally intended to restrict certain operations to more-trusted clients, like the cluster's own Workbench. However, in practice this mechanism has just made initial cluster setup more finicky, and made some token checking queries less efficient.

The TrustedClients config has made the api_clients.is_trusted mechanism redundant.

Proposed improvement

Delete the api_clients table and api_client_authorizations.api_client_id column.

(This is made awkward by the fact that tests and install docs still rely on api_client_id to decide whether to add a new token or use an existing one, etc.)