Project

General

Profile

Actions

Bug #21927

closed

lib/controller/handler_test.go TestDiscoveryDocCache fails intermittently

Added by Brett Smith 4 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Tests
Story points:
-
Release:
Release relationship:
Auto

Description

time="2024-06-20T21:26:27Z" level=warning msg="error refreshing cache" error="HTTP status 400" path=/discovery/v1/apis/arvados/v1/rest

----------------------------------------------------------------------
FAIL: handler_test.go:120: HandlerSuite.TestDiscoveryDocCache

handler_test.go:278:
    // Only one attempt to re-fetch (holdReqs ensured the first
    // update took long enough for the last incoming request to
    // arrive)
    c.Check(countRailsReqs(), check.Equals, reqsBefore+1)
... obtained int = 10
... expected int = 11

Note that we previously had #21276 to do some work on this. As far as I'm aware this is the first time we've seen a problem since that branch was merged six months ago.


Files


Subtasks 1 (0 open1 closed)

Task #22013: Review 21927-discovery-doc-testResolvedTom Clegg08/02/2024Actions

Related issues

Related to Arvados - Bug #21276: lib/controller/handler_test.go TestDiscoveryDocCache is raceyResolvedTom CleggActions
Has duplicate Arvados - Bug #21991: Unreliable test HandlerSuite.TestDiscoveryDocCache in lib/controllerDuplicateTom CleggActions
Actions #1

Updated by Brett Smith 4 months ago

  • Related to Bug #21276: lib/controller/handler_test.go TestDiscoveryDocCache is racey added
Actions #2

Updated by Brett Smith 4 months ago

  • Has duplicate Bug #21991: Unreliable test HandlerSuite.TestDiscoveryDocCache in lib/controller added
Actions #3

Updated by Brett Smith 4 months ago

  • Target version set to Development 2024-07-24 sprint
  • Assigned To set to Tom Clegg
Actions #4

Updated by Peter Amstutz 3 months ago

  • Target version changed from Development 2024-07-24 sprint to Development 2024-08-07 sprint
Actions #5

Updated by Tom Clegg 3 months ago

  • Status changed from New to In Progress

I was able to reproduce this by inserting a time.Sleep() at the top of (*cacheEnt)refresh(). Fix is explained in the commit message & comments.

21927-discovery-doc-test @ 8a633aa6872257548c4b63156a0031e3e74244ec -- developer-run-tests: #4364

Actions #6

Updated by Brett Smith 3 months ago

Tom Clegg wrote in #note-5:

21927-discovery-doc-test @ 8a633aa6872257548c4b63156a0031e3e74244ec -- developer-run-tests: #4364

LGTM, thanks.

Actions #7

Updated by Tom Clegg 3 months ago

  • Status changed from In Progress to Resolved
Actions #8

Updated by Peter Amstutz 2 months ago

  • Release set to 70
Actions

Also available in: Atom PDF