Project

General

Profile

Actions

Feature #21941

closed

Context menu option on collection files to get a link with the PDH and link directly to keep-web

Added by Peter Amstutz 5 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Story points:
-
Release:
Release relationship:
Auto

Description

  • Add context menu option on collection files to get a link identifier using the PDH instead of UUID. Should say something like "link to latest version" and "link to this exact version (immutable)"
  • Adjust links (both for UUID and PDH) so they go directly to keep-web.

The original reason for copy-to-clipboard to provide a workbench-based link (e.g. ?redirectToPreview=...) was that at the time, keep-web didn't support redirecting to workbench login if the user didn't have a API token cookie for the collection. Keep-web now knows how to redirect the browser to Workbench if necessary to log in, and while this uses the same ?redirectToPreview= mechanism that copy-to-clipboard currently uses, it is better to treat it as an internal implementation detail and avoid exposing it to the user for several reasons:

  • If the user uses "copy to clipboard" and gets a redirect link and wants to use it in something like curl, that won't work, because it requires loading and executing the entire Workbench web app
  • Similarly, even in the browser, the redirect link requires loading and executing the web app just to process the redirect, this adds several seconds. If the user already has a cookie, it will load the resource immediately.
  • You get different links if you visit the link and copy from the URL bar vs using "copy to clipboard" which feels bad, the links should be the same since they refer to the same resource.

Subtasks 1 (0 open1 closed)

Task #22023: Review 21941-keep-web-linkResolvedPeter Amstutz08/20/2024Actions

Related issues

Related to Arvados - Idea #21544: Convenient way to copy keep: URIsNewActions
Related to Arvados - Bug #22003: Client-side redirect in WB2 may target incorrect URL if path contains special charactersResolvedPeter AmstutzActions
Related to Arvados - Feature #22138: Collection context menu should offer all the same "copy to clipboard" actions as files/directories inside itNewActions
Actions #1

Updated by Brett Smith 5 months ago

  • Related to Idea #21544: Convenient way to copy keep: URIs added
Actions #2

Updated by Peter Amstutz 5 months ago

  • Description updated (diff)
Actions #3

Updated by Peter Amstutz 5 months ago

  • Description updated (diff)
Actions #4

Updated by Peter Amstutz 4 months ago

  • Target version changed from Development 2024-07-24 sprint to Development 2024-08-07 sprint
Actions #5

Updated by Peter Amstutz 4 months ago

  • Target version changed from Development 2024-08-07 sprint to Future
Actions #6

Updated by Peter Amstutz 3 months ago

  • Description updated (diff)
  • Subject changed from Context menu option on collection files to get a link identifier with the PDH instead of UUID to Context menu option on collection files to get a link with the PDH and link directly to keep-web
Actions #7

Updated by Peter Amstutz 3 months ago

  • Target version changed from Future to Development 2024-09-11 sprint
Actions #8

Updated by Peter Amstutz 3 months ago

  • Related to Bug #22003: Client-side redirect in WB2 may target incorrect URL if path contains special characters added
Actions #9

Updated by Peter Amstutz 3 months ago

  • Target version changed from Development 2024-09-11 sprint to Development 2024-08-07 sprint
  • Status changed from New to In Progress
Actions #10

Updated by Peter Amstutz 3 months ago

  • Assigned To set to Peter Amstutz
Actions #13

Updated by Peter Amstutz 3 months ago

  • Description updated (diff)

21941-keep-web-link @ c6f364e215992d39d970dd4a72f87750b668201a

developer-run-tests: #4372

  • All agreed upon points are implemented / addressed.
    • Now three distinct "copy to clipboard" actions for UUID, PDH, and CWL keep: identifier
    • Produces a keep-web URL instead of redirecting through workbench (as discussed above)
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • n/a
  • Code is tested and passing, both automated and manual, what manual testing was done is described
    • updated existing tests
  • Documentation has been updated.
    • n/a
  • Behaves appropriately at the intended scale (describe intended scale).
    • no change to scale
  • Considered backwards and forwards compatibility issues between client and server.
    • no change, redirectToPreview continues to be supported.
  • Follows our coding standards and GUI style guidelines.
    • Only changes menu items
Actions #14

Updated by Peter Amstutz 3 months ago

  • Target version changed from Development 2024-08-07 sprint to Development 2024-08-28 sprint
Actions #15

Updated by Lisa Knox 3 months ago

This all LGTM functionally, but aesthetically I think the new menu items make the context menu popup look kinda off. Perhaps setting the parenthetical text underneath the menu item in slightly smaller text, perhaps italicized, or greyed? Perhaps none of these because you might try it and find that it looks worse. Everything else LGTM.

Actions #16

Updated by Peter Amstutz 3 months ago

Lisa Knox wrote in #note-15:

This all LGTM functionally, but aesthetically I think the new menu items make the context menu popup look kinda off. Perhaps setting the parenthetical text underneath the menu item in slightly smaller text, perhaps italicized, or greyed? Perhaps none of these because you might try it and find that it looks worse. Everything else LGTM.

You are right, it is too much text, it makes the menu unbalanced.

I took out the extra explanation in the parenthesis and reworded it slightly.

21941-keep-web-link @ 719640952e42c32e732019c62ad3409cacc799bb

developer-run-tests: #4399

Actions #17

Updated by Lisa Knox 3 months ago

I think that looks a lot better, LGTM

Actions #18

Updated by Peter Amstutz 3 months ago

  • Status changed from In Progress to Resolved
Actions #19

Updated by Peter Amstutz 3 months ago

  • Release set to 70
Actions #20

Updated by Brett Smith about 2 months ago

  • Related to Feature #22138: Collection context menu should offer all the same "copy to clipboard" actions as files/directories inside it added
Actions

Also available in: Atom PDF