Arvados

Yes, arvados-cwl-runner should notice that the priority went to 0 and do something about it.

21993-wf-step-cancel @ e19c1309aa6bad138479da3a3a5dd737fca400b7

developer-run-tests: #4358

• All agreed upon points are implemented / addressed.
  • workflow steps cancelled before being run are now recognized and treated as failed steps
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • n/a
• Code is tested and passing, both automated and manual, what manual testing was done is described
  • manually tested by running a workflow, cancelling the step in workbench, and observing the workflow runner didn't terminate. Then implemented the fix, went through the same process, and the cancelled (state: Committed, priority: 0) workflow step is now recognized as a failed step.
• Documentation has been updated.
  • n/a
• Behaves appropriately at the intended scale (describe intended scale).
  • no changes to scale
• Considered backwards and forwards compatibility issues between client and server.
  • no issues, it now requests the 'priority' field from the container request, but that field has been in the container API from the very beginning
• Follows our coding standards and GUI style guidelines.
  • yes

This is a straightforward bugfix, the only unusual thing is that it took so long to notice that there was a problem.

Unit testing currently doesn't really cover the main loop of the workflow runner. Integration tests do execute the main loop but it is difficult to test exceptional cases.

This LGTM, thanks!