Bug #22027
closed
remove themes_for_rails dependency that is causing arvados-api-server package build/test to fail
Description
build-packages-ubuntu2204: #368
I believe this is the error:
13:33:55 Could not find themes_for_rails-0.5.1 in 13:33:55 https://github.com/arvados/themes_for_rails (at 13:33:55 /var/www/arvados-api/current/vendor/cache/themes_for_rails-ddf6e592b3b6@ddf6e59) 13:33:55 failed.
I don't know why this is happening all of a sudden, but a possible solution is to remove "themes_for_rails" entirely.
This gem was used a long time ago on workbench 1 to override a few generic pages with branded pages, but I don't know what it was used for in the API server. It seems like a source of risk.
Related issues
Updated by Brett Smith 10 days ago
- Related to Idea #1776: User receives automatic email notification when account gets activated added
Updated by Brett Smith 10 days ago
This dependency was added as part of #1776, apparently to make it easier to customize email notifications. See also 9c40a72521dbfb4244d48069e4754a342f800492.
Updated by Brett Smith 10 days ago
The reason this started happening recently is because the merge of #21814 triggered a new package build. Before that, the package build+test has been reusing the packages built since the July 3 merge of #21931. It's possible something changed in the gem world between July 3 and August 13 that causes this situation where the package build "succeeds" but the newly-generated package is uninstallable.
Updated by Brett Smith 10 days ago
There used to be theme configuration in API server. This was removed in 47abf19591c9816f88f83db9fd2cbe93e2262e79 - search the diff for "theme." The fact that we removed this hook five years ago and nobody noticed suggests to me that yeah, support isn't a priority. I would be curious whether or not we're still using it on Curii-managed clusters to customize outgoing emails though.
Updated by Peter Amstutz 10 days ago
Good investigation!
It's been possible to customize the welcome email in the config file since https://dev.arvados.org/issues/16874, the other emails that are sent are just admin notifications that don't really need customization.
So I think we can safely get rid of themes_for_rails with no loss of functionality.
Updated by Peter Amstutz 10 days ago
- Assigned To changed from Lucas Di Pentima to Peter Amstutz
Updated by Peter Amstutz 10 days ago
- Subject changed from arvados-api-server package build/test failing to remove themes_for_rails dependency that is causing arvados-api-server package build/test to fail
Updated by Peter Amstutz 10 days ago
22027-remove-themes-for-rails @ 7e347678e1839769c1f63d544f5a129724313d4c
Updated by Brett Smith 9 days ago
Peter Amstutz wrote in #note-10:
22027-remove-themes-for-rails @ 7e347678e1839769c1f63d544f5a129724313d4c
LGTM. I checked the config for all Curii-managed clusters to see if we were using it there. (Just because we removed it from the default config doesn't mean it wasn't still supported.) But there's no sign of that so yeah, I think we're good. Thanks.
Updated by Peter Amstutz 9 days ago
- Status changed from In Progress to Resolved