Project

General

Profile

Actions

Bug #22116

closed

Make sure transition from queued to running refreshes process page

Added by Peter Amstutz 3 months ago. Updated 10 days ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Story points:
-

Description

If websockets isn't connected, we should add a polling process that refreshes the process page status every 15-20 seconds.


Subtasks 1 (0 open1 closed)

Task #22249: Review 22116-process-panel-pollingResolvedPeter Amstutz12/09/2024Actions
Actions #1

Updated by Peter Amstutz 3 months ago

  • Target version changed from Development 2024-09-25 sprint to Development 2024-10-09 sprint
Actions #2

Updated by Peter Amstutz 3 months ago

  • Target version changed from Development 2024-10-09 sprint to Development 2024-10-23 sprint
Actions #3

Updated by Peter Amstutz 2 months ago

  • Target version changed from Development 2024-10-23 sprint to Development 2024-11-06 sprint
Actions #4

Updated by Peter Amstutz about 2 months ago

  • Description updated (diff)
Actions #5

Updated by Peter Amstutz about 2 months ago

  • Assigned To set to Stephen Smith
Actions #6

Updated by Peter Amstutz about 2 months ago

  • Target version changed from Development 2024-11-06 sprint to Development 2024-11-20
Actions #7

Updated by Stephen Smith about 1 month ago

  • Status changed from New to In Progress
Actions #8

Updated by Peter Amstutz about 1 month ago

  • Target version changed from Development 2024-11-20 to Development 2024-12-04
Actions #9

Updated by Stephen Smith 17 days ago

Changes at arvados|74ed0406d9a18e0792e975209d5ca5266822747c branch 22116-process-panel-polling
Tests developer-run-tests-services-workbench2: #1362

  • All agreed upon points are implemented / addressed.
    • Optimistically load container after starting process - provides immediate status badge feedback
    • Add polling to process panel when process is queued or running
    • Convert WebSocketService into singleton - allows easier checking of websocket status from any place in the codebase without needing to synchronize state to store
      • Moved websocket config parameters to connect() call instead of constructor so that consumers checking status don't need to pass anything to the constructor
      • Adds status getters that check the websocket status
    • Flip process polling on/off based on websocket connection status
    • Add some tests for websocket to test singleton behavior and WS subscription on open
    • Bump cross-spawn for CVE-2024-21538
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • n/a
  • Code is tested and passing, both automated and manual, what manual testing was done is described
    • Added test to check that WebSocketService behaves as a singleton to allow checking websocket connection status
  • Documentation has been updated.
    • n/a
  • Behaves appropriately at the intended scale (describe intended scale).
    • no change in scale
  • Considered backwards and forwards compatibility issues between client and server.
    • no changes
  • Follows our coding standards and GUI style guidelines.
    • no changes
Actions #10

Updated by Peter Amstutz 17 days ago

  • Target version changed from Development 2024-12-04 to Development 2025-01-08
Actions #11

Updated by Peter Amstutz 12 days ago

Stephen Smith wrote in #note-9:

Changes at arvados|74ed0406d9a18e0792e975209d5ca5266822747c branch 22116-process-panel-polling
Tests developer-run-tests-services-workbench2: #1362

  • All agreed upon points are implemented / addressed.
    • Optimistically load container after starting process - provides immediate status badge feedback
    • Add polling to process panel when process is queued or running
    • Convert WebSocketService into singleton - allows easier checking of websocket status from any place in the codebase without needing to synchronize state to store
      • Moved websocket config parameters to connect() call instead of constructor so that consumers checking status don't need to pass anything to the constructor
      • Adds status getters that check the websocket status
    • Flip process polling on/off based on websocket connection status
    • Add some tests for websocket to test singleton behavior and WS subscription on open
    • Bump cross-spawn for CVE-2024-21538
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • n/a
  • Code is tested and passing, both automated and manual, what manual testing was done is described
    • Added test to check that WebSocketService behaves as a singleton to allow checking websocket connection status
  • Documentation has been updated.
    • n/a
  • Behaves appropriately at the intended scale (describe intended scale).
    • no change in scale
  • Considered backwards and forwards compatibility issues between client and server.
    • no changes
  • Follows our coding standards and GUI style guidelines.
    • no changes

This LGTM!

Actions #12

Updated by Stephen Smith 12 days ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF