Arvados

Changes at arvados|74ed0406d9a18e0792e975209d5ca5266822747c branch 22116-process-panel-polling
Tests developer-run-tests-services-workbench2: #1362

• All agreed upon points are implemented / addressed.
  • Optimistically load container after starting process - provides immediate status badge feedback
  • Add polling to process panel when process is queued or running
  • Convert WebSocketService into singleton - allows easier checking of websocket status from any place in the codebase without needing to synchronize state to store
    • Moved websocket config parameters to connect() call instead of constructor so that consumers checking status don't need to pass anything to the constructor
    • Adds status getters that check the websocket status
  • Flip process polling on/off based on websocket connection status
  • Add some tests for websocket to test singleton behavior and WS subscription on open
  • Bump cross-spawn for CVE-2024-21538
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • n/a
• Code is tested and passing, both automated and manual, what manual testing was done is described
  • Added test to check that WebSocketService behaves as a singleton to allow checking websocket connection status
• Documentation has been updated.
  • n/a
• Behaves appropriately at the intended scale (describe intended scale).
  • no change in scale
• Considered backwards and forwards compatibility issues between client and server.
  • no changes
• Follows our coding standards and GUI style guidelines.
  • no changes

Stephen Smith wrote in #note-9:

Changes at arvados|74ed0406d9a18e0792e975209d5ca5266822747c branch 22116-process-panel-polling
Tests developer-run-tests-services-workbench2: #1362

• All agreed upon points are implemented / addressed.
  • Optimistically load container after starting process - provides immediate status badge feedback
  • Add polling to process panel when process is queued or running
  • Convert WebSocketService into singleton - allows easier checking of websocket status from any place in the codebase without needing to synchronize state to store
    • Moved websocket config parameters to connect() call instead of constructor so that consumers checking status don't need to pass anything to the constructor
    • Adds status getters that check the websocket status
  • Flip process polling on/off based on websocket connection status
  • Add some tests for websocket to test singleton behavior and WS subscription on open
  • Bump cross-spawn for CVE-2024-21538
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • n/a
• Code is tested and passing, both automated and manual, what manual testing was done is described
  • Added test to check that WebSocketService behaves as a singleton to allow checking websocket connection status
• Documentation has been updated.
  • n/a
• Behaves appropriately at the intended scale (describe intended scale).
  • no change in scale
• Considered backwards and forwards compatibility issues between client and server.
  • no changes
• Follows our coding standards and GUI style guidelines.
  • no changes

This LGTM!