Bug #22135
closed
Project view's loading indicator sometimes present on empty projects
Description
When navigating through different projects by clicking on the left hand side tree, sometimes the "No data found" and "No workflow runs found" message is not being rendered on empty projects.
The attached video file demonstrates the problem.
Files
Updated by Peter Amstutz 3 months ago
- Target version changed from Development 2024-09-25 sprint to Development 2024-10-09 sprint
Updated by Peter Amstutz 3 months ago
- Assigned To changed from Lisa Knox to Stephen Smith
Updated by Peter Amstutz 3 months ago
- Target version changed from Development 2024-10-09 sprint to Development 2024-10-23 sprint
Updated by Peter Amstutz 3 months ago
- Assigned To changed from Stephen Smith to Lisa Knox
Updated by Lisa Knox 3 months ago
- Status changed from New to In Progress
developer-run-tests-services-workbench2: #1240
22135-project-loading-indicator @ 2bcf7e2a294eeb4bb27762dcf5a2471782a23d4e
- ✅ All agreed upon points are implemented / addressed.
- ✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
- ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
- - Documentation has been updated.
- - Behaves appropriately at the intended scale (describe intended scale).
- - Considered backwards and forwards compatibility issues between client and server.
- ✅ Follows our coding standards and GUI style guidelines.
Updated by Lucas Di Pentima 3 months ago
Some comments:
- There're some linter warnings that would be easy to fix:
Line 188:46: Unexpected mix of '&&' and '||'. Use parentheses to clarify the intended order of operations no-mixed-operators - I wonder if we can somehow have a test that exercise this code path, doesn't need to be an e2e test if a unit test is simpler to write, but I think this kind of bugs are difficult to spot if they appear again and are untested.
Other than that, LGTM.
Updated by Lisa Knox 3 months ago
22135-project-loading-indicator @ cdf3c3dbe06f759b77bbf5cdcf8ff563b87b9138
developer-run-tests-services-workbench2: #1259
Done and done!
Updated by Lucas Di Pentima 3 months ago
- Test looks good except for one suspicion of mine: a "test-project" named project is created but the browser isn't told to navigate to it after login, correct? So this might pass now that there's no wf run on the admin's home project but may fail in the future.
- If my observation above is correct, everything would be ready to merge with that fixed, and also LGTM otherwise.
Thanks!
Updated by Lisa Knox 3 months ago
- Test looks good except for one suspicion of mine: a "test-project" named project is created but the browser isn't told to navigate to it after login, correct?
That is correct, the intention was to navigate to the created project (that we know will be empty) and make assertions there. It is now fixed and I will go ahead and merge. Thanks!
Updated by Lisa Knox 3 months ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|1d6290c69b9c340005b4ed00aef17ca33260a1c1.