Bug #22139
closed
Workflow description pane does not keep a consistent size, jumps around the page
Description
Steps to reproduce on tordo:
- New→Run a workflow
- Select the first workflow. Switch to the Inputs pane. It resizes.
- Go back to the Description pane. Select another workflow. It resizes again.
It seems like there's a "standard" size for the right-hand pane, but counterintuitively, the Description pane tends to grow and take more space if the description is shorter. It has the "correct" size with a longer Description like aws-s3-bulk-download.cwl.
A different issue on the same page, too small for me to bother with a separate issue: the menu item is called "Run a Workflow" but the dialog is called "Run Process." We should make these consistent. IMO it would be better to rename the dialog because AFAIK we can only launch whole workflows, not arbitrary processes.
Files
Updated by Brett Smith 5 months ago
Maybe helpful to reproduce: this seems to be more noticeable if your main Workbench pane is wider. e.g., maximized 16:9 window, narrow left navigation pane.
Updated by Peter Amstutz 4 months ago
- Target version set to Development 2024-10-23 sprint
- Assigned To set to Peter Amstutz
- Status changed from New to Resolved
Updated by Peter Amstutz 4 months ago
- Related to Bug #22153: Workflow picker resets on item selection added
Updated by Brett Smith 4 months ago
- Status changed from Resolved to New
Updated by Peter Amstutz 4 months ago
Could you make some screenshots or a video? I'm don't know if I'm just not understanding what you're saying, or "it works for me". Also, make sure you reload just in case you have and old workbench cached, the feature was just merged the other day.
However, in the course of clicking around to try and if anything funny happened I managed to crash the app:
Uncaught TypeError: e.id is undefined
kC workflow.ts:187
children workflow-description-card.tsx:123
renderInputsTable workflow-description-card.tsx:121
render workflow-description-card.tsx:84
React 11
unstable_runWithPriority scheduler.development.js:653
React 6
workflow.ts:187:14
kC workflow.ts:187
children workflow-description-card.tsx:123
map self-hosted:178
renderInputsTable workflow-description-card.tsx:121
render workflow-description-card.tsx:84
React 11
unstable_runWithPriority scheduler.development.js:653
React 6
Updated by Brett Smith 4 months ago
Made this with a Chromium Incognito window, which I basically never use so it shouldn't have anything cached, and indicates this also happens in Chrome as well as Firefox. What's bugging me is the way the widths of these two columns keeps changing as I click around.
Updated by Peter Amstutz 4 months ago
Brett Smith wrote in #note-8:
Made this with a Chromium Incognito window, which I basically never use so it shouldn't have anything cached, and indicates this also happens in Chrome as well as Firefox. What's bugging me is the way the widths of these two columns keeps changing as I click around.
That is so weird, I am not seeing anything like that. I'll play with it some more.
Updated by Lucas Di Pentima 4 months ago
- File panel-resize.mov panel-resize.mov added
Happens to me on Safari, attached video demo.
Updated by Peter Amstutz 4 months ago
I figured it out, the window need to be at least 1200 pixels in width, then it starts to jump around.
This seems to be on account of there being slightly different CSS based on a min-width media selector.
Currently trying to figure out what is different between min-width: 900px and min-width: 1200px that causes this.
Updated by Peter Amstutz 4 months ago
Actually, while this is related to window width, but it isn't a media query issue.
Making the root container use full width fixes it.
Updated by Peter Amstutz 4 months ago
Should be fixed in 6260432b4cf3f4f13022f8ffa5d59ddb5db04b49
Updated by Brett Smith 4 months ago
- Status changed from New to Resolved
Peter Amstutz wrote in #note-13:
Should be fixed in 6260432b4cf3f4f13022f8ffa5d59ddb5db04b49
Looks fixed to me, thank you.