Bug #22139
closed
Workflow description pane does not keep a consistent size, jumps around the page
Added by Brett Smith about 1 month ago.
Updated 7 days ago.
Description
Steps to reproduce on tordo:
- New→Run a workflow
- Select the first workflow. Switch to the Inputs pane. It resizes.
- Go back to the Description pane. Select another workflow. It resizes again.
It seems like there's a "standard" size for the right-hand pane, but counterintuitively, the Description pane tends to grow and take more space if the description is shorter. It has the "correct" size with a longer Description like aws-s3-bulk-download.cwl.
A different issue on the same page, too small for me to bother with a separate issue: the menu item is called "Run a Workflow" but the dialog is called "Run Process." We should make these consistent. IMO it would be better to rename the dialog because AFAIK we can only launch whole workflows, not arbitrary processes.
Files
- Description updated (diff)
Maybe helpful to reproduce: this seems to be more noticeable if your main Workbench pane is wider. e.g., maximized 16:9 window, narrow left navigation pane.
- Target version set to Development 2024-10-23 sprint
- Assigned To set to Peter Amstutz
- Status changed from New to Resolved
I believe I fixed this in #22153
- Related to Bug #22153: Workflow picker resets on item selection added
- Status changed from Resolved to New
Peter Amstutz wrote in #note-4:
I believe I fixed this in #22153
I can't confirm this. Just clicking through workflows in tordo, without any search term, I still see the column widths jump around. (Is it possible it's fixed when you have a search but not when you don't?)
Could you make some screenshots or a video? I'm don't know if I'm just not understanding what you're saying, or "it works for me". Also, make sure you reload just in case you have and old workbench cached, the feature was just merged the other day.
However, in the course of clicking around to try and if anything funny happened I managed to crash the app:
Uncaught TypeError: e.id is undefined
kC workflow.ts:187
children workflow-description-card.tsx:123
renderInputsTable workflow-description-card.tsx:121
render workflow-description-card.tsx:84
React 11
unstable_runWithPriority scheduler.development.js:653
React 6
workflow.ts:187:14
kC workflow.ts:187
children workflow-description-card.tsx:123
map self-hosted:178
renderInputsTable workflow-description-card.tsx:121
render workflow-description-card.tsx:84
React 11
unstable_runWithPriority scheduler.development.js:653
React 6
Made this with a Chromium Incognito window, which I basically never use so it shouldn't have anything cached, and indicates this also happens in Chrome as well as Firefox. What's bugging me is the way the widths of these two columns keeps changing as I click around.
Brett Smith wrote in #note-8:
Made this with a Chromium Incognito window, which I basically never use so it shouldn't have anything cached, and indicates this also happens in Chrome as well as Firefox. What's bugging me is the way the widths of these two columns keeps changing as I click around.
That is so weird, I am not seeing anything like that. I'll play with it some more.
Happens to me on Safari, attached video demo.
I figured it out, the window need to be at least 1200 pixels in width, then it starts to jump around.
This seems to be on account of there being slightly different CSS based on a min-width media selector.
Currently trying to figure out what is different between min-width: 900px and min-width: 1200px that causes this.
Actually, while this is related to window width, but it isn't a media query issue.
Making the root container use full width fixes it.
- Status changed from New to Resolved
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by