Project

General

Profile

Actions

Bug #22153

closed

Workflow picker resets on item selection

Added by Peter Amstutz 3 months ago. Updated 2 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Story points:
-
Release:
Release relationship:
Auto

Description

Steps to reproduce:

  1. Go to tordo
  2. Click on New -> Run a workflow
  3. Enter a search term such as "revsort"
  4. Click on any item in the list
  5. The search box will be cleared, and the list of items will reset

It appears that the item you clicked on will still be selected, so it is possible to launch it, but it is still very confusing to the user.


Subtasks 1 (0 open1 closed)

Task #22171: Review 22153-workflow-pickerResolvedPeter Amstutz10/08/2024Actions

Related issues 2 (0 open2 closed)

Related to Arvados - Bug #21838: Project picker search resetsResolvedStephen SmithActions
Related to Arvados - Bug #22139: Workflow description pane does not keep a consistent size, jumps around the pageResolvedPeter AmstutzActions
Actions #1

Updated by Peter Amstutz 3 months ago

  • Description updated (diff)
Actions #2

Updated by Peter Amstutz 3 months ago

  • Assigned To set to Peter Amstutz
Actions #3

Updated by Peter Amstutz 3 months ago

  • Related to Bug #21838: Project picker search resets added
Actions #4

Updated by Peter Amstutz 3 months ago

22153-workflow-picker @ 8def6b1aab0ed8eb4a0e45c23618bc756c97e804

developer-run-tests: #4488

  • All agreed upon points are implemented / addressed. Describe changes from pre-implementation design.
    • Selecting an item in the workflow list no longer clears search (the search entry was set to intentionally reset itself when the selection changed)
    • While I was at it, I added {limit: 200} to the query that gets the list of workflows. Previously it was limited to 100 workflows (default page size).
    • Also made some layout tweaks to improve usage of space.
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • Searching is done on the client side, but it ought to be doing server side search. Will be addressed in an overhaul of the workflow picker (#21292).
  • Code is tested and passing, both automated and manual, what manual testing was done is described.
    • Passes existing tests, did not add a new test.
  • New or changed UX/UX and has gotten feedback from stakeholders.
    • Waiting for reviewer comments
  • Documentation has been updated.
    • n/a no documentation for this UI
  • Behaves appropriately at the intended scale (describe intended scale).
    • Not sure if loading 200 workflows will create problems for the browser. This picking interface is due to be overhauled in 3.1, though.
  • Considered backwards and forwards compatibility issues between client and server.
    • no changes to client/server API
  • Follows our coding standards and GUI style guidelines.
    • comments
Actions #5

Updated by Peter Amstutz 3 months ago

  • Status changed from New to In Progress
Actions #6

Updated by Lisa Knox 2 months ago

Not related to the ticket - While testing I found myself in a situation where a workflow was selected but scrolled out of view and I was momentarily confused as to which workflow was having its details displayed on the right. I think having the selected workflow name displayed above the tabs the right side would make this more clear. Just a little UI nitpick

Otherwise LGTM

Actions #8

Updated by Lisa Knox 2 months ago

LGTM!

Actions #9

Updated by Peter Amstutz 2 months ago

  • Release set to 70
Actions #10

Updated by Peter Amstutz 2 months ago

  • Status changed from In Progress to Resolved
Actions #11

Updated by Peter Amstutz 2 months ago

  • Related to Bug #22139: Workflow description pane does not keep a consistent size, jumps around the page added
Actions

Also available in: Atom PDF