Arvados

22153-workflow-picker @ 8def6b1aab0ed8eb4a0e45c23618bc756c97e804

developer-run-tests: #4488

• All agreed upon points are implemented / addressed. Describe changes from pre-implementation design.
  • Selecting an item in the workflow list no longer clears search (the search entry was set to intentionally reset itself when the selection changed)
  • While I was at it, I added {limit: 200} to the query that gets the list of workflows. Previously it was limited to 100 workflows (default page size).
  • Also made some layout tweaks to improve usage of space.
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • Searching is done on the client side, but it ought to be doing server side search. Will be addressed in an overhaul of the workflow picker (#21292).
• Code is tested and passing, both automated and manual, what manual testing was done is described.
  • Passes existing tests, did not add a new test.
• New or changed UX/UX and has gotten feedback from stakeholders.
  • Waiting for reviewer comments
• Documentation has been updated.
  • n/a no documentation for this UI
• Behaves appropriately at the intended scale (describe intended scale).
  • Not sure if loading 200 workflows will create problems for the browser. This picking interface is due to be overhauled in 3.1, though.
• Considered backwards and forwards compatibility issues between client and server.
  • no changes to client/server API
• Follows our coding standards and GUI style guidelines.
  • comments

Not related to the ticket - While testing I found myself in a situation where a workflow was selected but scrolled out of view and I was momentarily confused as to which workflow was having its details displayed on the right. I think having the selected workflow name displayed above the tabs the right side would make this more clear. Just a little UI nitpick

Otherwise LGTM

22153-workflow-picker @ 035dee77605fbd04d72982e4f084c0d394ad4d12

developer-run-tests: #4493

LGTM!