Actions
Bug #22177
closedPaging "All processes" broken
Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Story points:
-
Release:
Release relationship:
Auto
Description
Visiting "All processes" it shows "0-0 of 0" and the arrow to go to the next page is disabled, but in fact there are more items to be shown.
Updated by Peter Amstutz 6 months ago
- Release set to 70
- Description updated (diff)
Updated by Stephen Smith 6 months ago
This seems to be a simple case of turning off resource type prefixing on the process type filter so that the container request api doesn't complain
--- a/services/workbench2/src/store/all-processes-panel/all-processes-panel-middleware-service.ts
+++ b/services/workbench2/src/store/all-processes-panel/all-processes-panel-middleware-service.ts
@@ -27,7 +27,8 @@ export class AllProcessesPanelMiddlewareService extends ProcessesMiddlewareServi
if (sup === null) { return null; }
const columns = dataExplorer.columns as DataColumns<string, ContainerRequestResource>;
- const typeFilters = serializeOnlyProcessTypeFilters(true)(getDataExplorerColumnFilters(columns, AllProcessesPanelColumnNames.TYPE));
+ const typeFilters = serializeOnlyProcessTypeFilters(false)(getDataExplorerColumnFilters(columns, AllProcessesPanelColumnNames.TYPE));
return joinFilters(sup, typeFilters);
}
}
Updated by Peter Amstutz 6 months ago
Stephen Smith wrote in #note-2:
This seems to be a simple case of turning off resource type prefixing on the process type filter so that the container request api doesn't complain
[...]
It should be using the group contents API, though?
Updated by Peter Amstutz 6 months ago
Stephen says the query is using group contents but the "count" is using container requests. It should use group contents for both.
Updated by Peter Amstutz 6 months ago
- Assigned To changed from Stephen Smith to Peter Amstutz
Updated by Peter Amstutz 6 months ago
22130-all-processes-paging @ c449e16ae6754c444ece098220b87322b86b4a60
- Use group contents instead of container_request endpoint so that the filters are the same
- Also fixed loadProject to bail out when called with an invalid uuid (this is because it was making an API call with
owner_uuid=all_processes
which would never work). - Also discovered that navigating to the process page would cause loadProcess to be called twice, resulting in a bunch of redundant API calls. Eliminated the unnecessary loadProcess call.
Updated by Peter Amstutz 6 months ago
- Status changed from In Progress to Resolved
Actions