Project

General

Profile

Actions

Bug #22177

closed

Paging "All processes" broken

Added by Peter Amstutz 21 days ago. Updated 10 days ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Workbench2
Story points:
-
Release:
Release relationship:
Auto

Description

Visiting "All processes" it shows "0-0 of 0" and the arrow to go to the next page is disabled, but in fact there are more items to be shown.


Subtasks 1 (0 open1 closed)

Task #22191: Review 22130-all-processes-paging ResolvedStephen Smith10/18/2024Actions
Actions #1

Updated by Peter Amstutz 21 days ago

  • Release set to 70
  • Description updated (diff)
Actions #2

Updated by Stephen Smith 20 days ago

This seems to be a simple case of turning off resource type prefixing on the process type filter so that the container request api doesn't complain

--- a/services/workbench2/src/store/all-processes-panel/all-processes-panel-middleware-service.ts
+++ b/services/workbench2/src/store/all-processes-panel/all-processes-panel-middleware-service.ts
@@ -27,7 +27,8 @@ export class AllProcessesPanelMiddlewareService extends ProcessesMiddlewareServi
         if (sup === null) { return null; }
         const columns = dataExplorer.columns as DataColumns<string, ContainerRequestResource>;

-        const typeFilters = serializeOnlyProcessTypeFilters(true)(getDataExplorerColumnFilters(columns, AllProcessesPanelColumnNames.TYPE));
+        const typeFilters = serializeOnlyProcessTypeFilters(false)(getDataExplorerColumnFilters(columns, AllProcessesPanelColumnNames.TYPE));
         return joinFilters(sup, typeFilters);
     }
 }

Actions #3

Updated by Peter Amstutz 20 days ago

Stephen Smith wrote in #note-2:

This seems to be a simple case of turning off resource type prefixing on the process type filter so that the container request api doesn't complain

[...]

It should be using the group contents API, though?

Actions #4

Updated by Peter Amstutz 19 days ago

Stephen says the query is using group contents but the "count" is using container requests. It should use group contents for both.

Actions #5

Updated by Peter Amstutz 19 days ago

  • Assigned To set to Stephen Smith
Actions #6

Updated by Peter Amstutz 11 days ago

  • Assigned To changed from Stephen Smith to Peter Amstutz
Actions #7

Updated by Peter Amstutz 11 days ago

22130-all-processes-paging @ c449e16ae6754c444ece098220b87322b86b4a60

  • Use group contents instead of container_request endpoint so that the filters are the same
  • Also fixed loadProject to bail out when called with an invalid uuid (this is because it was making an API call with owner_uuid=all_processes which would never work).
  • Also discovered that navigating to the process page would cause loadProcess to be called twice, resulting in a bunch of redundant API calls. Eliminated the unnecessary loadProcess call.

developer-run-tests: #4516

Actions #8

Updated by Peter Amstutz 11 days ago

  • Status changed from New to In Progress
Actions #9

Updated by Stephen Smith 10 days ago

This lgtm!

Actions #10

Updated by Peter Amstutz 10 days ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF