Arvados

developer-run-tests-services-workbench2: #1364

22231-browser-warnings @ f204b2c67bcdb745b33ab70169a87999385ce17f

• / All agreed upon points are implemented / addressed.
• ✅ Anything not implemented (discovered or discussed during work) has a follow-up story.
  • https://dev.arvados.org/issues/22337
  • https://dev.arvados.org/issues/22379
  • https://dev.arvados.org/issues/22380
  • https://dev.arvados.org/issues/22381
• ✅ Code is tested and passing, both automated and manual, what manual testing was done is described
  • Manually tested
• n/a New or changed UX/UX and has gotten feedback from stakeholders.
• n/a Documentation has been updated.
• ✅ Behaves appropriately at the intended scale (describe intended scale).
• ✅ Considered backwards and forwards compatibility issues between client and server.
  • no changes
• ✅ Follows our coding standards and GUI style guidelines.

• I eliminated all warnings that were practical and made tickets for those that require substantial rewrites or upgrades. I checked as many views and tables as I could think of, but it's likely that I missed a few.

developer-run-tests-services-workbench2: #1373

22231-browser-warnings @ e28e17b03ca79922ff81d0491331adb42c39f1aa

I had to revert the upgrade to the latest version of redux-form because the latest version introduces bugs that cannot be fixed without replacing redux-form. This reversion re-introduces at least 2 browser warnings, but since redux-form will eventually be replaced anyway, it seems like a moot point.

• Since react-loader-spinner isn't used anymore I think we can just remove it from package.json and yarn install to update yarn.lock
• There's a little trailing whitespace in collection-panel.tsx line 199 (I have files.trimTrailingWhitespace enabled in VSCode which handles this)

Aside from that it LGTM and good to merge!