Actions
Bug #22273
closed
Cluster activity report uses type hints that don't work in Python 3.8
Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Crunch
Target version:
Story points:
-
Release:
Release relationship:
Auto
Description
We need to support Python 3.8 because that's included in Ubuntu 20.04.
$ arv-cluster-activity -h
Traceback (most recent call last):
File "/opt/arvados/pyclients/bin/arv-cluster-activity", line 5, in <module>
from arvados_cluster_activity.main import main
File "/opt/arvados/pyclients/lib/python3.8/site-packages/arvados_cluster_activity/main.py", line 17, in <module>
from arvados_cluster_activity.report import ClusterActivityReport, aws_monthly_cost, format_with_suffix_base2
File "/opt/arvados/pyclients/lib/python3.8/site-packages/arvados_cluster_activity/report.py", line 33, in <module>
class ProjectSummary:
File "/opt/arvados/pyclients/lib/python3.8/site-packages/arvados_cluster_activity/report.py", line 36, in ProjectSummary
runs: dict[str, WorkflowRunSummary]
TypeError: 'type' object is not subscriptable
Updated by Brett Smith about 2 months ago
- Release set to 70
- Target version set to Development 2024-11-06 sprint
- Assigned To set to Brett Smith
Updated by Brett Smith about 2 months ago
- Status changed from New to In Progress
Updated by Brett Smith about 2 months ago
22273-arv-cluster-activity-bugfixes @ 894159209fb9f6b72cd928ea323d69b685aa8ca6 - developer-run-tests: #4548 (If Workbench fails there's no way it can be because of this branch.)
- All agreed upon points are implemented / addressed.
- This branch fixes two Python 3.8 compatibility bugs, as well as two bugs (one crash, one display oddity) that arise when you run the report without Prometheus credentials, per #22274. Individual commits have more detail.
- Anything not implemented (discovered or discussed during work) has a follow-up story.
- N/A
- Code is tested and passing, both automated and manual, what manual testing was done is described
- After this branch, I can run
arv-cluster-activitywith Python 3.8, either with or without Prometheus credentials, and it generates the expected output.
- After this branch, I can run
- Documentation has been updated.
- No change needed, just bug fixes
- Behaves appropriately at the intended scale (describe intended scale).
- No change in scale
- Considered backwards and forwards compatibility issues between client and server.
- Improves compatibility with Ubuntu 20.04 and older Python
- Follows our coding standards and GUI style guidelines.
- Yes
Updated by Peter Amstutz about 2 months ago
Brett Smith wrote in #note-4:
22273-arv-cluster-activity-bugfixes @ 894159209fb9f6b72cd928ea323d69b685aa8ca6 - developer-run-tests: #4548
(If Workbench fails there's no way it can be because of this branch.)
- All agreed upon points are implemented / addressed.
- This branch fixes two Python 3.8 compatibility bugs, as well as two bugs (one crash, one display oddity) that arise when you run the report without Prometheus credentials, per #22274. Individual commits have more detail.
- Anything not implemented (discovered or discussed during work) has a follow-up story.
- N/A
- Code is tested and passing, both automated and manual, what manual testing was done is described
- After this branch, I can run
arv-cluster-activitywith Python 3.8, either with or without Prometheus credentials, and it generates the expected output.- Documentation has been updated.
- No change needed, just bug fixes
- Behaves appropriately at the intended scale (describe intended scale).
- No change in scale
- Considered backwards and forwards compatibility issues between client and server.
- Improves compatibility with Ubuntu 20.04 and older Python
- Follows our coding standards and GUI style guidelines.
- Yes
LGTM
Updated by Brett Smith about 2 months ago
- Status changed from In Progress to Resolved
Actions