Project

General

Profile

Actions

Bug #22298

closed

update local.params.example

Added by Peter Amstutz about 1 month ago. Updated 16 days ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Story points:
-

Description

https://gist.githubusercontent.com/zoe-translates/800530a5955fd82f267359eda857f376/raw/22aaedbd599c9b9437a2e2e0ef90b024a536b037/fix-installer-sh-syntax.patch

On further examination, what the patch does is make this work:

# The mapping of nodes to roles
# installer.sh will log in to each of these nodes and then provision
# it for the specified roles.
NODES=(
  [demo.vir-test.home.arpa]=''
)

I think this triggers a default "install everything" behavior in the provision.sh script, but it would be much better (and not require the installer.sh patch) if it was written this way:

NODES=(
  [demo.vir-test.home.arpa]='database,controller,monitoring,workbench,workbench2,webshell,keepproxy,keepweb,websocket,dispatcher,keepbalance,keepstore'
)

The reason for the confusion is that local.params.example.single_host_single_hostname uses the blank version, and it wasn't tested properly.


Subtasks 1 (0 open1 closed)

Task #22382: Review 22298-local-paramsResolvedPeter Amstutz12/05/2024Actions
Actions #1

Updated by Peter Amstutz about 1 month ago

  • Status changed from New to In Progress
Actions #2

Updated by Peter Amstutz about 1 month ago

  • Description updated (diff)
Actions #3

Updated by Peter Amstutz about 1 month ago

  • Target version changed from Development 2024-11-06 sprint to Development 2024-11-20
Actions #4

Updated by Peter Amstutz about 1 month ago

  • Assigned To set to Peter Amstutz
Actions #5

Updated by Peter Amstutz about 1 month ago

  • Target version changed from Development 2024-11-20 to Development 2024-12-04
Actions #6

Updated by Peter Amstutz 17 days ago

  • Target version changed from Development 2024-12-04 to Development 2025-01-08
Actions #7

Updated by Peter Amstutz 16 days ago

  • Description updated (diff)
Actions #8

Updated by Peter Amstutz 16 days ago

  • Subject changed from installer.sh syntax tweak from Zoe to update local.params.example
Actions #9

Updated by Peter Amstutz 16 days ago

22298-local-params @ 82e05db0eb7139c770364b316f0358fab5e98132

  • Applied Zoe's patch.
  • Explicitly list out all the roles except "shell" in the single node examples.
Actions #10

Updated by Lucas Di Pentima 16 days ago

I believe you forgot pushing Zoe's patch or maybe applied it on another branch?

Otherwise LGTM

Actions #11

Updated by Peter Amstutz 16 days ago

Lucas Di Pentima wrote in #note-10:

I believe you forgot pushing Zoe's patch or maybe applied it on another branch?

I applied it but didn't stage it for commit. Oops.

Otherwise LGTM

Thanks

Actions #12

Updated by Peter Amstutz 16 days ago

  • Status changed from In Progress to Resolved
Actions

Also available in: Atom PDF