Bug #22358
closed
Autocomplete properties drop down when editing project is unscrollable when too long
Added by Stephen Smith 3 months ago.
Updated 21 days ago.
Release relationship:
Auto
Description
When editing a project, the properties key/value suggestion dropdown boxes show all available options at first, which extends below the bottom of the browser window and is unscrollable. Ideally it should be scrollable as well as stop before the bottom of the window to ensure the last item is selectable.
- Target version changed from Development 2024-12-04 to Development 2025-01-08
- Subject changed from Long properties drop down when editing project is unscrollable to Autocomplete properties drop down when editing project is unscrollable when too long
- Target version changed from Development 2025-01-08 to Development 2025-01-29
- Assigned To set to Stephen Smith
- Status changed from New to In Progress
- Status changed from In Progress to New
- Target version changed from Development 2025-01-29 to Development 2025-02-12
- Status changed from New to In Progress
- Target version changed from Development 2025-02-12 to Development 2025-02-26
Changes at arvados|bd2007a6843d9c5f433448eaf1be78c7ab0ba3ac branch 22358-fix-overflowing-autocomplete
Tests developer-run-tests-services-workbench2: #1442 
- All agreed upon points are implemented / addressed.
- Added popper modifier to autocomplete (and participant select used in sharing dialog) to limit height and scroll instead of overflowing outside window
- Also added force flip to top/bottom if less than 2 suggestions are visible and if there is more space on the other side
- Bumped parse-duration for CVE-2025-25283
- Anything not implemented (discovered or discussed during work) has a follow-up story.
- Code is tested and passing, both automated and manual, what manual testing was done is described
- Passed automated tests
- Manual tests:
- opening autocomplete near bottom of window - should scroll
- scroll or resize - should adapt to new window height
- scroll or resize to force popper to the top - should scroll and not overflow top
- popper should flip directions if less than 2 suggestions are visible
- Documentation has been updated.
- Behaves appropriately at the intended scale (describe intended scale).
- Considered backwards and forwards compatibility issues between client and server.
- Follows our coding standards and GUI style guidelines.
- no significant change to design
I should note that there is an edge case where the autocomplete dropdown will go off page if the input field is scrolled off page, but I don't think it's important to handle that case since it would be a medium amount of work to conditionally detach the popper anchor to handle a use case that shouldn't be normal (window so small that the input field itself isn't visible), and since the primary use case for this ticket is too many suggestions in the dropdown. Plus, if you type in the input field, it will scroll back and fix the overflow.
Agreed that the edge case isn't worth pursuing. If a user triggers that edge case, they have their window so small as to make workbench unusable anyway.
LGTM
- Status changed from In Progress to Resolved
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by