Project

General

Profile

Actions

Bug #22437

closed

Move Ansible stuff to a dedicated directory

Added by Brett Smith about 1 month ago. Updated 10 days ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Deployment
Target version:
Story points:
-

Description

Our Ansible stuff currently lives under tools/compute-images because that was the first thing we used it for. It has already expanded beyond that and expect it will continue to do so.

I suggest it get its own tools subdirectory, probably just tools/ansible, but I'm open to bikeshedding on the exact name.

Changes that need to follow:

  • Packer configuration needs to be updated to point to the new paths.
  • Suggest organizing playbooks under a dedicated playbooks subdirectory while we're doing this, to leave more room for things to grow under the Ansible subdirectory.
  • Update the compute node build documentation as necessary.
  • Update the Hacking prerequisites wiki page as necessary.

Jenkins shouldn't need any changes because it just calls Packer.


Subtasks 1 (0 open1 closed)

Task #22447: Review 22437-ansible-dirResolvedBrett Smith01/28/2025Actions
Actions #1

Updated by Peter Amstutz about 1 month ago

  • Subtask #22447 added
Actions #2

Updated by Brett Smith 17 days ago

  • Status changed from New to In Progress

Brett Smith wrote:

  • Suggest organizing playbooks under a dedicated playbooks subdirectory while we're doing this, to leave more room for things to grow under the Ansible subdirectory.

I have decided not to do this because it goes against Ansible's own recommended directory structure and thwarts the default logic for finding roles. We could configure that differently if it was important but it isn't right now and I would rather not add complications we don't need yet.

Actions #3

Updated by Brett Smith 17 days ago

22437-ansible-dir @ 1983b5ea74f4a76ea373ca4ca24d8667ddca6ccc - packer-build-compute-image: #304 (this ran against the previous commit, but the latest commit only fixes a typo in a developer README so it's fiiine)

  • All agreed upon points are implemented / addressed.
    • With the caveat above about deciding against the playbooks subdirectory, does everything that can be done in the branch.
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • I will update the wiki as part of this issue but it doesn't make sense to do until after the branch is merged.
  • Code is tested and passing, both automated and manual, what manual testing was done is described
    • See above. That is the only way we run playbooks that isn't completely manual so if it works, anything can.
  • Documentation has been updated.
    • Yes
  • Behaves appropriately at the intended scale (describe intended scale).
    • No change in scale
  • Considered backwards and forwards compatibility issues between client and server.
    • N/A
  • Follows our coding standards and GUI style guidelines.
    • N/A
Actions #4

Updated by Tom Clegg 11 days ago

22437-ansible-dir LGTM, thanks.

Actions #5

Updated by Brett Smith 11 days ago

  • Status changed from In Progress to Resolved
Actions #6

Updated by Brett Smith 11 days ago

Branch merged, wiki updated.

Actions

Also available in: Atom PDF