Arvados

From discussion: will switch from proportional width splitter to fixed pixel width for the left panel.

Changes at arvados|a73c6a635f96353881d1662af84246830aa8eec4 branch 22566-left-sidebar-scroll-bug
Tests developer-run-tests-services-workbench2: #1452

• All agreed upon points are implemented / addressed.
  • Fixed overflow scroll using word-break & remove inner min-width
  • Enforce min-width in the resizer by switching to pixel mode
    • Switched "primary panel" to middle panel so that main panel gets extra space when resizing
    • Removed handling of details panel transitions not needed for pixel mode
    • Fixed collapsed side panel to 50px instead of calculating from percent
  • Removed isTransitioning, currentSideWidth, actions, reducers, and observer only needed for handling percent mode
  • Trigger resize on the nested SplitterLayout when parent is resized to properly recalculate nested split and prevent permanently squashing the details panel out of existence (it comes back now)
    • It's not perfectly ideal that the details panel can get squashed using the left panel, but setting a min-width results in the left panel taking priority when the whole window gets squashed, as opposed to the details panel getting squashed first, which I think is preferable
  • Clamp saved values to minimums so that old saved percents won't cause issues
• Anything not implemented (discovered or discussed during work) has a follow-up story.
  • none
• Code is tested and passing, both automated and manual, what manual testing was done is described
  • Passed tests
  • Tested with resizing panels to their limits at different window sizes and opening/closing them in all orders
• Documentation has been updated.
  • no change
• Behaves appropriately at the intended scale (describe intended scale).
  • no change
• Considered backwards and forwards compatibility issues between client and server.
  • none
• Follows our coding standards and GUI style guidelines.
  • no significant design changes

• It might be preferable for the left side min width to be slightly smaller, because when all menu items are collapsed there is a ton of whitespace. I suspect this might throw the word wrap way off when menu items are expanded, though, so maybe keep the same it if that's the case
• If I squish the details panel and then click the "Toggle side panel" button, the details panel is gone and there is no way to get it back except to untoggle the side panel and then re-embiggen the main panel. I suggest getting the details panel min width to reset when the "Toggle side panel" button is clicked. The pop-in shouldn't matter because the left panel is already popping.

• In workbench.tsx:
  • L325 minSidePanelSplitterSize is assigned the value of defaultSidePanelSplitterSize and is then used exactly once. We should just use defaultSidePanelSplitterSize instead, unless the plan is to have these two numbers be different in the future.
  • L326 & L335 These two functions are basically the same, and neither takes any arguments. I suggest combining them into one that takes the localStorage key and the appropriate min size.
  • saveSidePanelSplitterSize and saveDetailsSplitterSize could also be combined with a conitional for the handlResize(), which I think would improve the visual clarity
  • There are strings representing localStorage keys and classnames, and I feel like any time a string is used more than once it should be replaced with a constant.

Also from eslint:
src/views/workbench/workbench.tsx
Line 5:17: 'useEffect' is defined but never used @typescript-eslint/no-unused-vars
Line 5:28: 'useState' is defined but never used @typescript-eslint/no-unused-vars

Changes at arvados|8c84b7a355d626e35d9a17d2e7f45c2ada9fb2de
Test developer-run-tests-services-workbench2: #1457

• Removed unused imports
• Decreased min left panel size to just as much as the category labels need
• Added call to resize handler when left panel collapses/uncollapses
• Min and default left panel size is different now so no redundant variables
• Refactored set/get functions to handle both panels by accepting a settings type that contains the storage key and min/default values - also eliminates duplicated usage of storage keys
• Replaced custom class with disabled property for more terse code and eliminate magic class name
• Also added style to eliminate horizontal scroll on collapsed sidebar

Beauutiful, LGTM