Project

General

Profile

Actions

Feature #22568

open

Update workbench2 to properly display "GPU" runtime constraint

Added by Peter Amstutz 10 days ago. Updated 1 day ago.

Status:
In Progress
Priority:
Normal
Assigned To:
Category:
Workbench2
Target version:
Story points:
-
Release relationship:
Auto

Files

resource-panel-with-gpu.png (56.7 KB) resource-panel-with-gpu.png Peter Amstutz, 02/21/2025 07:57 PM

Subtasks 1 (0 open1 closed)

Task #22575: Review 22568-wb2-gpuResolvedStephen Smith02/21/2025Actions

Related issues 1 (0 open1 closed)

Related to Arvados - Feature #21926: AMD ROCm GPU supportResolvedPeter AmstutzActions
Actions #1

Updated by Peter Amstutz 10 days ago

  • Position changed from -937680 to -937679
Actions #2

Updated by Peter Amstutz 10 days ago

  • Assigned To set to Peter Amstutz
Actions #3

Updated by Peter Amstutz 10 days ago

Actions #4

Updated by Peter Amstutz 10 days ago

  • Subtask #22575 added
Actions #5

Updated by Peter Amstutz 2 days ago

  • Release set to 75
Actions #7

Updated by Peter Amstutz 1 day ago

  • All agreed upon points are implemented / addressed. Describe changes from pre-implementation design.
    • Workbench now handles runtime_constraints and InstanceType structs containing a generic "GPU" section instead of the platform specific "CUDA" section
  • Anything not implemented (discovered or discussed during work) has a follow-up story.
    • n/a
  • Code is tested and passing, both automated and manual, what manual testing was done is described.
    • Passes automated tests. Manually created container records and inspected the rendering to make sure there were no issues.
  • New or changed UX/UX and has gotten feedback from stakeholders.
    • It is a relatively minor change. I suppose we could run this by the group, otherwise the reviewer can make the call.
  • Documentation has been updated.
    • n/a
  • Behaves appropriately at the intended scale (describe intended scale).
    • No change in scale
  • Considered backwards and forwards compatibility issues between client and server.
    • Records that only contain "CUDA" will no longer show up, but because requests with "CUDA" are translated on the API server side, that would only happen if newer Workbench was talking to an older API server. Currently we only support newer workbench talking to older API server in very limited federation cases. This kind of thing could be bigger issue in the future, but I don't think it is an issue now.
  • Follows our coding standards and GUI style guidelines.
    • Yes

In the course of testing, I also fixed a few issues in arvados-cwl-runner around default values and ensuring that expressions are evaluated in CUDARequirement and ROCmRequirement.

Actions #8

Updated by Peter Amstutz 1 day ago

  • Status changed from New to In Progress
Actions #9

Updated by Stephen Smith 1 day ago

This lgtm!

Actions

Also available in: Atom PDF