Arvados

Currently, the toolbar can display either just above the data table in a data explorer or in the details card on projects and root projects. There is also a slightly different display for the subprocesses data explorer. The calculations to determine where the toolbar should show up are spread out over several files, weighing factors from several other components, and are far more complicated than they likely need to be. This makes the toolbar display prone to bugs (as we've seen) and makes it harder to work on, taking more of the devs' time to fix the bugs that inevitably occur.

Ideally, all of the calculations that determine where the toolbar should go would be in one place, and we could just call the component <MultiselectToolbar /> wherever it should go, knowing that it will only display there when appropriate, instead of code like this:

{!this.state.hideToolbar
                        && (this.props.isSelectedResourceInDataExplorer || isMoreThanOneSelected(this.props.checkedList))
                        && (this.multiSelectToolbarInTitle
                            ? <MultiselectToolbar injectedStyles={classes.msToolbarStyles} />
                            : <MultiselectToolbar
                                    forceMultiSelectMode={forceMultiSelectMode}
                                    injectedStyles={classNames(panelName === 'Subprocesses' ? classes.subToolbarWrapper : panelName === 'Runs' ? classes.runsToolbarWrapper : '')}/>)
                    }