Project

General

Profile

Actions
Copy link

Bug #22666

closed

Add tests that keepstore.BlockRead properly handles CheckCacheOnly option

Added by Brett Smith 15 days ago. Updated 1 day ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Tom Clegg
Category:
Keep
Target version:
Development 2025-04-02
Story points:
-

Description

This behavior was added in #22320 as part of a larger branch, for API consistency. IMO we should have tests that this specific function handles the option properly. This is expected to be straightforward, it just didn't happen in the original branch because of scheduling issues around a release.

Subtasks 1 (0 open — 1 closed)

Task #22682: Review 22666-test-checkcacheonlyResolvedTom Clegg03/27/2025Actions

Related issues 1 (0 open — 1 closed)

Follows (7 days) Arvados - Feature #22320: Add Repack(opts RepackOptions) method to collectionfs, dirnode, and filehandleResolvedTom CleggActions
Actions
Copy link
 #1

Updated by Brett Smith 15 days ago

  • Follows Feature #22320: Add Repack(opts RepackOptions) method to collectionfs, dirnode, and filehandle added
Actions
Copy link
 #2

Updated by Peter Amstutz 13 days ago

  • Assigned To set to Tom Clegg
Actions
Copy link
 #3

Updated by Peter Amstutz 13 days ago

  • Subtask #22682 added
Actions
Copy link
 #4

Updated by Tom Clegg 8 days ago

  • Status changed from New to In Progress
Actions
Copy link
 #5

Updated by Brett Smith 7 days ago

Tom Clegg wrote in #note-4:

22666-test-checkcacheonly @ 25bbe5b3ed49a77110773f06abfabebe4a61d116 -- developer-run-tests: #4710

My one comment suggestion would be in the docstring, rather than saying "currently," spell that out as Arvados 3.1.0/March 2025, to clarify the context it's being written in. But either way this LGTM, thank you.

Actions
Copy link
 #6

Updated by Tom Clegg 5 days ago

  • Status changed from In Progress to Resolved
Actions
Copy link

Also available in: Atom PDF