Project

General

Profile

Actions

Task #2440

closed

Review 2228-check-filter-uuid-columns

Added by Peter Amstutz about 10 years ago. Updated about 10 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:

Related issues

Blocks Arvados - Feature #2228: In create and update, assign/check _kind attributes by inspecting corresponding _uuid.ResolvedPeter Amstutz03/24/2014Actions
Actions #1

Updated by Tom Clegg about 10 years ago

  • Status changed from New to In Progress
  • Start date set to 03/26/2014
Actions #2

Updated by Tom Clegg about 10 years ago

  • Assigned To set to Tom Clegg
  • Estimated time set to 1.00 h
  • Remaining (hours) set to 1.0
Actions #3

Updated by Tom Clegg about 10 years ago

  • Migration loses data. If anything goes wrong, we can't just deploy an old version; everything is screwed until we fix all the bugs (or hastily write a real down-migration). Either
    • Make the down-migration restore the contents of the fields to what they were before, instead of leaving them null, or
    • Leave the database fields there (but don't use them in API responses) until we have deployed and we're confident everything works.
  • "Combine selected collections" → "Can't mass-assign protected attributes: tail_kind, head_kind". grep -r reveals a bunch of *_kind stuff in apps/workbench and crunch_scripts/pgp-survey-import. (Should merge master, then try grep; new stuff in 2187.)
  • We should (at least) ignore provided *_kind in create/update, and (as a convenience to the client) generate *_kind in API responses. Then our (and our poor users', if any) clients won't suddenly start failing.
    • Crashing when receiving *_kind makes jobs unrepeatable if people used *_kind like we told them to in their scripts (or just ran our example script).

As an aside, perhaps we should consider a deprecation approach -- e.g., include warnings in API responses, and make SDKs print them on stderr?

Actions #4

Updated by Tom Clegg about 10 years ago

  • Assigned To changed from Tom Clegg to Peter Amstutz
Actions #5

Updated by Peter Amstutz about 10 years ago

  • Assigned To changed from Peter Amstutz to Tom Clegg
  • Down migration restores fields from head/tail_uuid type
  • API will continue to accept head/tail_kind in create requests, head/tail returned in link GET responses, and users can still use where head/tail_kind
  • Combine selected files tested, works
Actions #6

Updated by Tom Clegg about 10 years ago

  • Target version changed from 2014-03-26 Debt service and dev painkillers to 2014-04-16 Dev tools and data/resource management
Actions #7

Updated by Tom Clegg about 10 years ago

  • Assigned To changed from Tom Clegg to Peter Amstutz
Actions #8

Updated by Peter Amstutz about 10 years ago

  • Assigned To changed from Peter Amstutz to Tom Clegg
Actions #9

Updated by Tom Clegg about 10 years ago

  • Assigned To changed from Tom Clegg to Peter Amstutz
Actions #10

Updated by Peter Amstutz about 10 years ago

  • Assigned To changed from Peter Amstutz to Tom Clegg
Actions #11

Updated by Peter Amstutz about 10 years ago

  • Status changed from In Progress to Resolved
  • Remaining (hours) changed from 1.0 to 0.0
Actions

Also available in: Atom PDF