Feature #2501

Much more flexible consent forms

Added by Phil Hodgson almost 6 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Phil Hodgson
Category:
-
Start date:
04/01/2014
Due date:
% Done:

75%

Estimated time:
(Total: 0.00 h)
Story points:
-

Subtasks

Task #2504: Make the consent form allow for (an) additional question(s)ResolvedPhil Hodgson

Task #2528: review more flexible consent form codeResolvedPhil Hodgson

Task #2532: Site-specific validation for additional consent questionsResolvedPhil Hodgson

Task #2530: Text and textarea helpers for more flexible consent formsResolvedPhil Hodgson


Related issues

Blocks Tapestry - Story #2549: Configurable Signup ConditionsResolved04/08/2014

History

#1 Updated by Phil Hodgson almost 6 years ago

  • Subject changed from PGP.CA can sign-up according to their requirements to PGP.ca allows sign-up according to site-specific requirements

#2 Updated by Ward Vandewege almost 6 years ago

  • Target version changed from Tapestry - Next sprint to Testing and Upgrading + PGP.ca features

#3 Updated by Ward Vandewege almost 6 years ago

  • Subject changed from PGP.ca allows sign-up according to site-specific requirements to Much more flexible consent forms

#4 Updated by Ward Vandewege almost 6 years ago

  • Assigned To set to Phil Hodgson

Since this code is not in a separate branch (I think?), I reviewed these commits:

435659ab7864a40447b728e6e802de1687250ff6
8636ca6855492297dc7286366fa06773df3199c6
6d3d50d7c4ed400e9d7dc8686cb3190b24f4eded
b05f26f66885d5a5ba4e5dfd2e68207df9bd7fe4

Review notes:

  • commit 435659ab7864a40447b728e6e802de1687250ff6 introduces whitespace at the end of a few lines.
  • commit 435659ab7864a40447b728e6e802de1687250ff6:

I like where this is going. A few thoughts:

a) the documentation in lib/site_specific/validations.rb is great. I wonder if it belongs on the Tapestry wiki in a 'Customization' section that should also include the bits about internationalization and theming (already present on the wiki, feel free to reorganize). The validations.rb file could have a pointer to the docs. What do you think? I'm not 100% sure on the best place for these docs: it makes sense to have them close to the code, but customizing Tapestry is going to be a very common occurrence, and I think it would be valuable to have all relevant documentation in one place. On the wiki for now, maybe in the future we'll have a proper documentation tree like we have for Arvados.

b) Is there a way to have people put custom validations in a separate file? That would be preferrable to avoid git merge conflicts and facility upgrades.

c) the documentation in validations.rb does not yet refer to the file overlay scheme from #2518. It probably should?

  • commit b05f26f66885d5a5ba4e5dfd2e68207df9bd7fe4 introduces whitespace at the end of a few lines.

#5 Updated by Phil Hodgson almost 6 years ago

  • Status changed from New to In Progress

You can now refer to branch 2501-flexibler-consent for these commits and new ones which address your comments the best I can.

Note: b05f26f66885d5a5ba4e5dfd2e68207df9bd7fe4 is actually not part of this branch.

#6 Updated by Ward Vandewege almost 6 years ago

Reviewing the 2501-flexibler-consent branch:

in 7dd2baccae83c8b23de04811019d125c65f36b80 you mention

ActiveSupport::Dependencies.explicitly_unloadable_constants << 'SiteSpecific::Validations'

which people should add to their development.rb. Can you add it to config/development.rb.example? It seems that line was dropped from the doc on https://arvados.org/projects/tapestry/wiki/Customization -- was that intentional?

Other than that, this looks great and I think it's ready to merge. Thanks!

#7 Updated by Phil Hodgson almost 6 years ago

  • Status changed from In Progress to Resolved

Wiki documentation updated and branch merged.

Also available in: Atom PDF