Story #2502

Make all the site-specific labels configurable

Added by Phil Hodgson almost 6 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Phil Hodgson
Category:
Tapestry structural improv.
Start date:
04/01/2014
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Subtasks

Task #2534: Turn non-view, site-specific string literals into translationsResolvedPhil Hodgson

Task #2536: Review 2502-site-labelsResolvedPhil Hodgson

Associated revisions

Revision 9334a92c (diff)
Added by Phil Hodgson almost 6 years ago

Another signup correction (refs #2502)

Revision d67937cf (diff)
Added by Phil Hodgson almost 6 years ago

Turn occurrences outside of the views of phrases specific to "the PGP" or "personalgenomes.org" into translations (fixes #2534, refs #2502)

History

#1 Updated by Phil Hodgson almost 6 years ago

  • Subject changed from Make all the site-specific one-liners configurable to Make all the site-specific labels configurable

#2 Updated by Ward Vandewege almost 6 years ago

  • Parent task deleted (#2501)

#3 Updated by Ward Vandewege almost 6 years ago

  • Tracker changed from Task to Story

#4 Updated by Phil Hodgson almost 6 years ago

On review it seems to me that there is every reason to use the #2518 functionality to override views on a site-specific basis. The fact is that it is much more than simply the name "The PGP" and so on that need to be reviewed and re-rewritten by each site, so it seems pointless to parameterize these phrases within the views. I therefore limited my changes to the minimal ones that would remove from anything outside of the views those occurrences of certain strings identified by Joe. A much more thorough job could be done, but it will take a lot of time, and many of the non-view hard-codings of strings should actually be refactored in a more consistent way to begin with. Furthermore, we will probably change the way many enrollment forms work in a fundamental way, to make the system more dynamic and configurable, and that will be the best time to refactor all the many, many other hard-coded strings.

#5 Updated by Ward Vandewege almost 6 years ago

Reviewing 2502-site-labels

7e7c32f7883e674e6c2a648f94c74987144405d3:

This change is not correct; the signup path linked here should be changed to a configuration parameter that, for Harvard, will be set to

http://www.personalgenomes.org/harvard/sign-up

So please add a signup_link parameter to config/config.defaults.yml and set the default to '/signup'. I will override it in our Harvard deploy config to the link above. And please add a comment there that signup_link should probably be changed to the signup page for the project on the personalgenomes.org site.

Other than that, I agree with your assessment to make the changes outside views this way, and let the references to 'the PGP' etc be inside the views, since they can now be overridden via the site_specific directory.

Good to merge once the above change is made!

Thanks,
Ward.

#6 Updated by Phil Hodgson almost 6 years ago

  • Status changed from New to Resolved

The new config setting has been added ('signup_url') and the 2502 branch merged to master.

Also available in: Atom PDF