Task #2506
closed
Bug #2447: Workbench search is broken - it always returns everything
Review 2447-fix-workbench-search branch.
Description
I note searching for owner_uuid is explicitly disallowed. Should there be similar restrictions on the links table? As in, presumably we probably don't want the links table searchable?
Not sure why b0542ec0dd2bb6fbf040d1c7d719e7fa4d82d58a is in this branch but it seems to make sense too.
Good to merge, I think.
Updated by Ward Vandewege almost 11 years ago
- Description updated (diff)
- Assigned To set to Ward Vandewege
Updated by Tom Clegg almost 11 years ago
Tom Clegg wrote:
I note searching for owner_uuid is explicitly disallowed. Should there be similar restrictions on the links table? As in, presumably we probably don't want the links table searchable?
Non-permission Links should still be searchable (for tags) but yes, searching permissions might be pretty useless. Like owner_uuid, it won't expose anything that shouldn't be exposed, just cause a bunch of probably-uninteresting results to be included.
Not sure why b0542ec0dd2bb6fbf040d1c7d719e7fa4d82d58a is in this branch but it seems to make sense too.
Fixed it to make Workbench's built-in profiling/debugging stuff start working again.
Good to merge, I think.
Merging.
Updated by Tom Clegg almost 11 years ago
- Status changed from New to Resolved
- Remaining (hours) changed from 1.0 to 0.0