Task #2546
closed
Idea #2533: Basic clean-up of tests, as a foundation for working on specific ones
Review remaining code from refactor-tests branch
Added by Phil Hodgson about 10 years ago.
Updated almost 10 years ago.
Description
Following up on #2419/#2420, we'll want to merge that code into master, so that the basic changes that allowed `rake test` to run can be part of Phil's efforts to further the coding of other tests.
Reviewing refactor-tests branch:
- hoptoad is not unused (af28f69133abde76fd2b65131dbd836773f82598), though it
is site-specific for harvard PGP. There is now an airbrake plugin for redmine,
so we could switch to that. And probably should. I think it's ok to leave this commit in, just wanted to mention it.
- To fix: introducing some whitespace at end of lines (cf.
app/controllers/users_controller.rb in accept_tos, app/model/user.rb in log,
test/functional/admin/mailing_lists_controller_test.rb,
vendor/plugins/restful-authentication/lib/authentication/by_cookie_token.rb). I suggest you
- For future reference: I noticed you made changes in the vendor/plugins
directory too; that's probably a waste of time since those will go away as we
upgrade to rails 3.2.
- Otherwise, I think this branch is good to merge into master.
- Status changed from New to Resolved
- Start date set to 05/21/2014
- Remaining (hours) set to 0.0
Changes made according to your comments and all merged to master.
Also available in: Atom
PDF
Updated by 
Updated by Phil Hodgson