Actions
Task #2581
closed
Idea #1776: User receives automatic email notification when account gets activated
Review 1776 implementation
Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Target version:
Updated by Radhika Chippada about 10 years ago
The email related work is straightforward.
To add themes_for_rails to services/api, in addition to repeating the steps in workbench, I also had to add the following statement to the "application_controller.rb" : include ThemesForRails::ActionController
Updated by Tim Pierce about 10 years ago
- Status changed from New to In Progress
- Assigned To set to Radhika Chippada
The code looks good to me here. Nice tests.
- services/api/config/application.default.yml
- I'd like to ensure that Arvados doesn't accidentally send mail notifications with a bogus domain like example.com. Does the email domain for
admin_notifier_email_fromanduser_notifier_email_fromget changed somewhere? Or are we simply relying on the admin to change it to something useful manually when they configure Arvados?
- I'd like to ensure that Arvados doesn't accidentally send mail notifications with a bogus domain like example.com. Does the email domain for
Updated by Radhika Chippada about 10 years ago
According to Ward, these will be configured to the correct / desired values in production.
Updated by Tim Pierce about 10 years ago
Radhika Chippada wrote:
According to Ward, these will be configured to the correct / desired values in production.
OK, I'll follow up on that separately, but this LGTM. Feel free to merge and close the issues :-)
Updated by Radhika Chippada about 10 years ago
Tim reviewed and approved of the changes.
Updated by Radhika Chippada about 10 years ago
- Status changed from In Progress to Resolved
- Remaining (hours) set to 0.0
Tim reviewed the code updates.
Actions