https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422014-04-16T15:37:17ZArvadosArvados - Idea #2612: Workbench displays user usage in logshttps://dev.arvados.org/issues/2612?journal_id=97062014-04-16T15:37:17ZMisha Zatsmanmisha@curoverse.com
<ul><li><strong>Project</strong> changed from <i>35</i> to <i>Arvados</i></li></ul> Arvados - Idea #2612: Workbench displays user usage in logshttps://dev.arvados.org/issues/2612?journal_id=97172014-04-16T15:47:05ZMisha Zatsmanmisha@curoverse.com
<ul><li><strong>Target version</strong> set to <i>2014-05-07 Storing and Organizing Data</i></li></ul> Arvados - Idea #2612: Workbench displays user usage in logshttps://dev.arvados.org/issues/2612?journal_id=97422014-04-16T16:16:26ZMisha Zatsmanmisha@curoverse.com
<ul><li><strong>Story points</strong> set to <i>1.0</i></li></ul> Arvados - Idea #2612: Workbench displays user usage in logshttps://dev.arvados.org/issues/2612?journal_id=98232014-04-17T20:29:14ZMisha Zatsmanmisha@curoverse.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/9823/diff?detail_id=7885">diff</a>)</li></ul> Arvados - Idea #2612: Workbench displays user usage in logshttps://dev.arvados.org/issues/2612?journal_id=98502014-04-22T16:27:24ZMisha Zatsmanmisha@curoverse.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/9850/diff?detail_id=7931">diff</a>)</li></ul> Arvados - Idea #2612: Workbench displays user usage in logshttps://dev.arvados.org/issues/2612?journal_id=98622014-04-23T12:43:38ZTom Cleggtom@curii.com
<ul></ul>As of <a class="changeset" title="Merge branch 'master' of git.curoverse.com:arvados into 2612-workbench-displays-user-storage" href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/7f7cd27d5fc31dc5bbec7f95905fd394a5b317c7">7f7cd27d5fc31dc5bbec7f95905fd394a5b317c7</a>, taking into account "work in progress" caveat
<ul>
<li>Only complaint I see is that <code>.to_s</code> is superfluous in <code>@user_storage[user.uuid][key].to_s</code> (<code><%= blah %></code> does that implicitly)</li>
<li>Route, view, controller stuff all looks right to me</li>
</ul> Arvados - Idea #2612: Workbench displays user usage in logshttps://dev.arvados.org/issues/2612?journal_id=98932014-04-23T17:31:51ZMisha Zatsmanmisha@curoverse.com
<ul></ul><p>Tom Clegg wrote:</p>
<blockquote>
<p>As of <a class="changeset" title="Merge branch 'master' of git.curoverse.com:arvados into 2612-workbench-displays-user-storage" href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/7f7cd27d5fc31dc5bbec7f95905fd394a5b317c7">7f7cd27d5fc31dc5bbec7f95905fd394a5b317c7</a>, taking into account "work in progress" caveat</p>
</blockquote>
<blockquote>
<ul>
<li>Only complaint I see is that <code>.to_s</code> is superfluous in <code>@user_storage[user.uuid][key].to_s</code> (<code><%= blah %></code> does that implicitly)</li>
</ul>
</blockquote>
<p>Ok great, I fixed that.</p>
<blockquote>
<ul>
<li>Route, view, controller stuff all looks right to me</li>
</ul>
</blockquote>
<p>Cool.</p>
<p>I made it prettier, and now it's ready for a real review.</p>
<p>I don't think my page is reachable from any existing pages. Where and how do I add a link to it?</p> Arvados - Idea #2612: Workbench displays user usage in logshttps://dev.arvados.org/issues/2612?journal_id=98982014-04-23T19:42:41ZTom Cleggtom@curii.com
<ul></ul><p>Looks great. Only complaint I could find:</p>
<p>Some "tab in indent" complaints from git. <a class="external" href="https://arvados.org/projects/arvados/wiki/Coding_Standards">https://arvados.org/projects/arvados/wiki/Coding_Standards</a> has ways to make git report whitespace errors (<code>git diff --check</code>) and prevent you from committing them (although this means you have to use --no-verify to commit or merge Go code -- we figured Go's strong 8-char-tab convention trumps our preference for no tabs). And emacs/vim bits to tell them to auto-indent with spaces.</p>
<blockquote>
<p>I don't think my page is reachable from any existing pages. Where and how do I add a link to it?</p>
</blockquote>
<p>For the moment, closest we have to a good place to put it: <code>apps/workbench/app/views/users/_show_activity.html.erb</code></p> Arvados - Idea #2612: Workbench displays user usage in logshttps://dev.arvados.org/issues/2612?journal_id=99322014-04-24T16:22:10ZMisha Zatsmanmisha@curoverse.com
<ul></ul><p>Tom Clegg wrote:</p>
<blockquote>
<p>Looks great. Only complaint I could find:</p>
<p>Some "tab in indent" complaints from git. <a class="external" href="https://arvados.org/projects/arvados/wiki/Coding_Standards">https://arvados.org/projects/arvados/wiki/Coding_Standards</a> has ways to make git report whitespace errors (<code>git diff --check</code>) and prevent you from committing them (although this means you have to use --no-verify to commit or merge Go code -- we figured Go's strong 8-char-tab convention trumps our preference for no tabs). And emacs/vim bits to tell them to auto-indent with spaces.</p>
</blockquote>
<p>Thanks. I have those bits in my .emacs but added the git config stuff. The tabs seem to have come from activity.html.erb from which I pasted in pieces.</p>
<blockquote><blockquote>
<p>I don't think my page is reachable from any existing pages. Where and how do I add a link to it?</p>
</blockquote>
<p>For the moment, closest we have to a good place to put it: <code>apps/workbench/app/views/users/_show_activity.html.erb</code></p>
</blockquote>
<p>Cool, I added it in. I'm weirded out by ruby creating magic strings like storage_users_url and not defining them anywhere I can grep for them, but it seems to work.</p> Arvados - Idea #2612: Workbench displays user usage in logshttps://dev.arvados.org/issues/2612?journal_id=99342014-04-24T16:45:16ZAnonymous
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>25</i> to <i>100</i></li></ul><p>Applied in changeset arvados|commit:416374d4bbf381f5689fe2d1c72705d0796e8382.</p>