Arvados

• Only complaint I see is that .to_s is superfluous in @user_storage[user.uuid][key].to_s (<%= blah %> does that implicitly)
• Route, view, controller stuff all looks right to me

Tom Clegg wrote:

As of 7f7cd27d5fc31dc5bbec7f95905fd394a5b317c7, taking into account "work in progress" caveat

• Only complaint I see is that .to_s is superfluous in @user_storage[user.uuid][key].to_s (<%= blah %> does that implicitly)

Ok great, I fixed that.

• Route, view, controller stuff all looks right to me

Cool.

I made it prettier, and now it's ready for a real review.

I don't think my page is reachable from any existing pages. Where and how do I add a link to it?

Looks great. Only complaint I could find:

Some "tab in indent" complaints from git. https://arvados.org/projects/arvados/wiki/Coding_Standards has ways to make git report whitespace errors (git diff --check) and prevent you from committing them (although this means you have to use --no-verify to commit or merge Go code -- we figured Go's strong 8-char-tab convention trumps our preference for no tabs). And emacs/vim bits to tell them to auto-indent with spaces.

I don't think my page is reachable from any existing pages. Where and how do I add a link to it?

For the moment, closest we have to a good place to put it: apps/workbench/app/views/users/_show_activity.html.erb

Tom Clegg wrote:

Looks great. Only complaint I could find:

Some "tab in indent" complaints from git. https://arvados.org/projects/arvados/wiki/Coding_Standards has ways to make git report whitespace errors (git diff --check) and prevent you from committing them (although this means you have to use --no-verify to commit or merge Go code -- we figured Go's strong 8-char-tab convention trumps our preference for no tabs). And emacs/vim bits to tell them to auto-indent with spaces.

Thanks. I have those bits in my .emacs but added the git config stuff. The tabs seem to have come from activity.html.erb from which I pasted in pieces.

I don't think my page is reachable from any existing pages. Where and how do I add a link to it?

For the moment, closest we have to a good place to put it: apps/workbench/app/views/users/_show_activity.html.erb

Cool, I added it in. I'm weirded out by ruby creating magic strings like storage_users_url and not defining them anywhere I can grep for them, but it seems to work.