Project

General

Profile

Actions
Copy link

Task #2725

closed

Idea #2352: Pipeline instance state is represented with a state machine instead of "active" and "success" flags

2352-use-state branch is ready for review

Added by Radhika Chippada about 10 years ago. Updated almost 10 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Target version:
2014-05-28 Pipeline Factory

Description

Tom,
Please review the "second" phase, where the arv-run-pipeline-instance is updated to handle RunningOnClient and Paused states.

A couple questions:

1. In pipeline_instance.rb: how about I merge the code from the "verify_status" method into "update_success"? I can call this method as "update_success_and_verify_status". Concern being, I am not sure if it is guaranteed that update_success method is executed "before" the verify_status method and if there is a situation where this becomes an issue otherwise.

2. components_summary: # 1. Do we want to call "done" as "succeeded"? # 2. How to determine "running"?

Actions
Copy link

Also available in: Atom PDF