Bug #2744

Developer doc bug-fixes

Added by Tom Clegg over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
-
Category:
-
Start date:
12/02/2013
Due date:
% Done:

100%

Estimated time:
(Total: 7.50 h)
Story points:
1.0

Subtasks

Task #2696: Fix install doc bugsResolvedTom Clegg

Task #2729: Building python egg should go in sdk/python/python-sdk.html and install/client.html should just tell you to use "pip install"ResolvedWard Vandewege

Task #2737: Document "filters" parameterResolvedTom Clegg

Task #2738: Call new log records "log entry" instead of "log" on log methods pageResolvedTom Clegg

Task #2747: Review 2744-update-dev-docs branchResolvedMisha Zatsman

Associated revisions

Revision 8fcba378
Added by Tom Clegg over 7 years ago

Merge branch '2744-update-dev-docs'

closes #2744

History

#1 Updated by Misha Zatsman over 7 years ago

Looks good, just a few minor points:

test "search jobs by uuid with 'not in' query":
Can you provide multiple real uuids for the set which the uuids are not in? Otherwise this test looks just like the test that follows.
test "search jobs by output with '!= nil' query":
Are there any jobs with output = nil?
If not, then this test will always pass regardless of the correctness of the filter (unless it gets really weird), right?
If there are can you please add a test for output = nul as well?

#2 Updated by Tom Clegg over 7 years ago

Misha Zatsman wrote:

test "search jobs by uuid with 'not in' query":
Can you provide multiple real uuids for the set which the uuids are not in? Otherwise this test looks just like the test that follows.

Indeed. Fixed.

Are there any jobs with output = nil?
If there are can you please add a test for output = nul as well?

Yes. Rearranged tests as matched pairs of "=" and "!=", each with an assert_not_empty to ensure something actually has to get filtered out in the other.

#3 Updated by Anonymous over 7 years ago

  • Status changed from New to Resolved

Applied in changeset arvados|commit:8fcba3783d9a79bb18a00d339f9b3222f1eccd7f.

Also available in: Atom PDF