Bug #2744
closed
Looks good, just a few minor points:
test "search jobs by uuid with 'not in' query":
Can you provide multiple real uuids for the set which the uuids are not in? Otherwise this test looks just like the test that follows.
test "search jobs by output with '!= nil' query":
Are there any jobs with output = nil?
If not, then this test will always pass regardless of the correctness of the filter (unless it gets really weird), right?
If there are can you please add a test for output = nul as well?
Misha Zatsman wrote:
test "search jobs by uuid with 'not in' query":
Can you provide multiple real uuids for the set which the uuids are not in? Otherwise this test looks just like the test that follows.
Indeed. Fixed.
Are there any jobs with output = nil?
If there are can you please add a test for output = nul as well?
Yes. Rearranged tests as matched pairs of "=" and "!=", each with an assert_not_empty to ensure something actually has to get filtered out in the other.
- Status changed from New to Resolved
Applied in changeset arvados|commit:8fcba3783d9a79bb18a00d339f9b3222f1eccd7f.
Also available in: Atom
PDF