Task #2851

Story #2503: Make it possible to disable/enable "sections"

Review 2503

Added by Phil Hodgson almost 6 years ago. Updated almost 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Phil Hodgson
Category:
-
Start date:
04/07/2014
Due date:
% Done:

0%

Estimated time:

Description

As agreed in email between Ward and Phil, because of an inadvertent merge we're going finish this story one up more or less at the stage it is at. At least, based on the story title, we can say that it is now "possible" to define sections of Tapestry, and that we're evolving a methodology for doing this. This story will be continued in #2850.

History

#1 Updated by Ward Vandewege almost 6 years ago

  • Assigned To changed from Ward Vandewege to Phil Hodgson

This command shows differences between the 2503-disablable-sections branch (locally checked out) and tapestry-master, thus showing me what to review:

$ git cherry tapestry-master
+ 008dbe5a8418e90daef8b5505877530f800b3ccd
+ 7036c65159410d8e42e618ff3a9942f3018f5e35
+ 934fcd0cf878487d44e6a7b66217588e4219273f
+ 97d2b4ab7530563e345c4ffcbebe93e2c58585aa

008dbe5a8418e90daef8b5505877530f800b3ccd:

app/views/pages/introduction.html.erb line 23 refers to PUBLIC_DATA where it should be PUBLIC_PROFILE
app/views/pages/sitemap.html.erb line 46 remove tabs at start of line (use spaces)

934fcd0cf878487d44e6a7b66217588e4219273f: there is still one reference to #{Rails.root}/config/config.yml that needs replacing with site_config_filepath

97d2b4ab7530563e345c4ffcbebe93e2c58585aa: looks good.

Otherwise, good to merge I think!

#2 Updated by Phil Hodgson almost 6 years ago

  • Status changed from New to Resolved
  • Remaining (hours) set to 0.0

Also available in: Atom PDF