Feature #2428: upgrade to ruby 1.9.3
Make all tests pass and without deprecation warnings in 1.8.7
Bug fix: resident attribute could be nil which should also be considered false (refs #2930)
Fixes deprecation notification for using email body as a hash to create email instance variables (refs #2930)
- different access to url_helpers
- specifying host when sending email
- removing reference to TMail - not the mailer we use (and anyway it came from vendor's generator)
Adjustment to recent fix: by using _path instead of _url one can avoid specifying the host (refs #2930)
Fix tests to look for redirection to the "unauthorized" page rather than the login page (refs #2930)
Bug fix because it was having somehow giving a FixNum for params[:id] (refs #2930)
Fixes for admin user controller and its tests. Using has_many :through to associate a user with their mailing list subscriptions. (refs #2930)
Rewrite oath_services controller tests to make them do something along the lines of what the existing tests intended (refs #2930)
Fixes distinctive traits survey functional tests and the views and controllers themselves (there were broken aspects) (refs #2930)
Interestingly, a new login context was created, for imitating an 'enrolled' user enough to get past security filters.
Note that the slider in distinctive_traits_survey show.html.erb has been removed as it no longer worked. It can be re-instated if there are any strong objections, but I judged it not worth the time to figure out why it was broken.
Makes device types functional tests work, and adds a 'logged in as researcher' context to the login test macros (refs #2930)
Updating functional tests so that they all pass, are appropriate, and have no deprecations (refs #2930)
Devised better way of handling testing of controllers not in the 'fixture' set of enrollment steps: just factory the one enrollment step
Functional tests now all passing for identity confirmation controller (refs #2930)
Interesting commit because a general improvement was made to how current_user is handled in tests: now stubbing it to @user
Getting more functional tests to pass where they were failing and/or giving deprecation warnings (refs #2930)
Passwords controller test passing (refs #2930)
Changed controllers to use redirection after updating password
Make removal requests tests pass and move to appropriate directory, but also fix bugs discovered in removal requests pages and controller (refs #2930)
Notable bug was that there was no admin security on the controller.
Can be necessary to get enrolled user tests passing (recent safety questionnaire and consents) - also better to use factories (refs #2930)
Shipping address functional tests passing (refs #2930)
Removed gmaps as they were making tests unpredictable but they should also be tested (added a should_eventually to this effect)
Withdrawal comment factory should have been with previous commit (refs #2930)
Tissue types, trait collections, and units controller tests passing (refs #2930)
In a recent commit the relation between mailing list and users had been upgraded to meet deprecation notices - the test had not been updated to correspond to the change (refs #2930)
#4 Updated by Phil Hodgson about 7 years ago
Annoying deprecation warning on
should_not_allow_values_for: we should switch to
should allow_value(*values).for(attribute) but if there is more than one value we get a too many arguments error! This must be because of where shoulda is frozen in the Gemfile currently (see commit 89c0d5a02686bbd8b9746ce1849d880a7cd2b0a7). I can't get rid of the deprecation "properly" without separating these calls onto many lines (as I had to for
validates_presence_of), and since I believe the problem will disappear after we upgrade Ruby and the shoulda gem, I'm going to leave these in and fix them when Ruby and shoulda gets upgraded. As long as there aren't too many exceptions like this, we should be able to keep things under control.
#5 Updated by Phil Hodgson about 7 years ago
There are a series of tests related to
User#in_screening_eligibility_group but it seems as if Tapestry grew out of using such groupings. There is no longer this method in the User model. However, there seem to be a residual controller and a lot of "waitlist" logic in the code base, and it's not yet clear to me whether all of this has been abandoned and should be removed entirely (which would help clean things up a bit, to be sure!), or whether this code should be maintained in the event that similar Enrollment Steps and conditions will be applicable again in the future.
In the meantime I am going to at least remove the in_screening_eligibility_group tests, since it can't make sense to test a method that was removed.