Task #2930

Feature #2428: upgrade to ruby 1.9.3

Make all tests pass and without deprecation warnings in 1.8.7

Added by Phil Hodgson almost 6 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Phil Hodgson
Category:
-
Start date:
06/30/2014
Due date:
% Done:

0%

Estimated time:

Associated revisions

Revision 3ee5be3d (diff)
Added by Phil Hodgson over 5 years ago

Bug fix: resident attribute could be nil which should also be considered false (refs #2930)

Revision c9782282 (diff)
Added by Phil Hodgson over 5 years ago

Fixes deprecation notification for using email body as a hash to create email instance variables (refs #2930)

Revision 59c4640e (diff)
Added by Phil Hodgson over 5 years ago

Fixes most Shoulda deprecation notices (refs #2930)
Exception is the should_allow_values_for deprecation: see https://arvados.org/issues/2930#note-4

Revision 4a0edb17 (diff)
Added by Phil Hodgson over 5 years ago

Fixes out-of-date enrollment step keywords used during tests (refs #2930)

Revision d74dfd2b (diff)
Added by Phil Hodgson over 5 years ago

Remove tests never used or referencing removed code (refs #2930)

Revision 80ccace7 (diff)
Added by Phil Hodgson over 5 years ago

Fixes Errors#on deprecation notices, and related (refs #2930)

Revision 238546c9 (diff)
Added by Phil Hodgson over 5 years ago

Fixes UserMailerTest deprecations and errors (refs #2930)
  • different access to url_helpers
  • specifying host when sending email
  • removing reference to TMail - not the mailer we use (and anyway it came from vendor's generator)

Revision 67f7b03a (diff)
Added by Phil Hodgson over 5 years ago

Adjustment to recent fix: by using _path instead of _url one can avoid specifying the host (refs #2930)

Revision f8ca75de (diff)
Added by Phil Hodgson over 5 years ago

Controller test refactoring for Shoulda deprecations (refs #2930)

Revision ae2bade0 (diff)
Added by Phil Hodgson over 5 years ago

Fix tests to look for redirection to the "unauthorized" page rather than the login page (refs #2930)

Revision d33beacf (diff)
Added by Phil Hodgson over 5 years ago

Bug fix because it was having somehow giving a FixNum for params[:id] (refs #2930)

Revision 52fe162e (diff)
Added by Phil Hodgson over 5 years ago

Fixes for admin user controller and its tests. Using has_many :through to associate a user with their mailing list subscriptions. (refs #2930)

Revision a43d80de (diff)
Added by Phil Hodgson over 5 years ago

Rewrite oath_services controller tests to make them do something along the lines of what the existing tests intended (refs #2930)

Revision cd0bf774 (diff)
Added by Phil Hodgson over 5 years ago

Fixes distinctive traits survey functional tests and the views and controllers themselves (there were broken aspects) (refs #2930)
Interestingly, a new login context was created, for imitating an 'enrolled' user enough to get past security filters.
Note that the slider in distinctive_traits_survey show.html.erb has been removed as it no longer worked. It can be re-instated if there are any strong objections, but I judged it not worth the time to figure out why it was broken.

Revision 026d5fd7 (diff)
Added by Phil Hodgson over 5 years ago

Makes device types functional tests work, and adds a 'logged in as researcher' context to the login test macros (refs #2930)

Revision 5a223575 (diff)
Added by Phil Hodgson over 5 years ago

Updating functional tests so that they all pass, are appropriate, and have no deprecations (refs #2930)
Devised better way of handling testing of controllers not in the 'fixture' set of enrollment steps: just factory the one enrollment step

Revision 523bb314 (diff)
Added by Phil Hodgson over 5 years ago

Functional tests now all passing for identity confirmation controller (refs #2930)
Interesting commit because a general improvement was made to how current_user is handled in tests: now stubbing it to @user

Revision 26ec5705 (diff)
Added by Phil Hodgson over 5 years ago

Kit design and kit design sample functional tests (refs #2930)

Revision 79d6938c (diff)
Added by Phil Hodgson over 5 years ago

Getting more functional tests to pass where they were failing and/or giving deprecation warnings (refs #2930)

Revision 27a27195 (diff)
Added by Phil Hodgson over 5 years ago

Passwords controller test passing (refs #2930)
Changed controllers to use redirection after updating password

Revision f7683085 (diff)
Added by Phil Hodgson over 5 years ago

PHR controller tests passing (refs #2930)

Revision b268da8b (diff)
Added by Phil Hodgson over 5 years ago

Plates controller tests passing (refs #2930)

Revision 825740d7 (diff)
Added by Phil Hodgson over 5 years ago

Pledges controller tests passing (refs #2930)

Revision f4a6fa8e (diff)
Added by Phil Hodgson over 5 years ago

Make removal requests tests pass and move to appropriate directory, but also fix bugs discovered in removal requests pages and controller (refs #2930)
Notable bug was that there was no admin security on the controller.

Revision b63dccfb (diff)
Added by Phil Hodgson over 5 years ago

Passing samples and sample types functional tests (refs #2930)

Revision 964fad6a (diff)
Added by Phil Hodgson over 5 years ago

Screening submissions functional tests passing (refs #2930)

Revision d368a3c5 (diff)
Added by Phil Hodgson over 5 years ago

Screening surveys tests now passing (refs #2930)

Revision 2ad2918e (diff)
Added by Phil Hodgson over 5 years ago

Passing studies (collection events) controller tests (refs #2930)

Revision c880ca5a (diff)
Added by Phil Hodgson over 5 years ago

Waitlist resubmissions functional tests passing (refs #2930)

Revision d432abfb (diff)
Added by Phil Hodgson over 5 years ago

Withdrawal comments functional tests passing (refs #2930)

Revision a44d0bee (diff)
Added by Phil Hodgson over 5 years ago

Can be necessary to get enrolled user tests passing (recent safety questionnaire and consents) - also better to use factories (refs #2930)

Revision 2087c193 (diff)
Added by Phil Hodgson over 5 years ago

Shipping address functional tests passing (refs #2930)
Removed gmaps as they were making tests unpredictable but they should also be tested (added a should_eventually to this effect)

Revision b3236d53 (diff)
Added by Phil Hodgson over 5 years ago

Users controller functional tests passing (refs #2930)

Revision d7328228 (diff)
Added by Phil Hodgson over 5 years ago

Withdrawal comment factory should have been with previous commit (refs #2930)

Revision 6918984e (diff)
Added by Phil Hodgson over 5 years ago

Unused kit names functional tests passing (refs #2930)

Revision fc9b7610 (diff)
Added by Phil Hodgson over 5 years ago

Fix deprecation notices for functional tests (refs #2930)

Revision 72c8bec4 (diff)
Added by Phil Hodgson over 5 years ago

Sessions controller tests passing (refs #2930)

Revision 33dc996c (diff)
Added by Phil Hodgson over 5 years ago

Tissue types, trait collections, and units controller tests passing (refs #2930)

Revision 380fef76 (diff)
Added by Phil Hodgson over 5 years ago

In a recent commit the relation between mailing list and users had been upgraded to meet deprecation notices - the test had not been updated to correspond to the change (refs #2930)

Revision d49f8dbe
Added by Ward Vandewege almost 3 years ago

Merge branch 'tapestry-master' into 2930-passing-tests

refs #2930

Revision 955ddbba (diff)
Added by Ward Vandewege almost 3 years ago

Fix one of the content_area tests.

refs #2930

Revision 01e37083 (diff)
Added by Ward Vandewege almost 3 years ago

Fix QuestionResponseTest.

refs #2930

Revision a20d7126 (diff)
Added by Ward Vandewege almost 3 years ago

Add comment for removing deprecation warning in the future.

refs #2930

Revision 326818f3 (diff)
Added by Ward Vandewege almost 3 years ago

Fix a bunch more functional tests.

refs #2930

Revision 215e5bfe (diff)
Added by Ward Vandewege almost 3 years ago

Fix remaining functional tests.

refs #2930

Revision a311a556 (diff)
Added by Ward Vandewege almost 3 years ago

Remove mysql-ism from the user model.

refs #2930

Revision d4b2440f (diff)
Added by Ward Vandewege almost 3 years ago

Add infrastructure to run the tests inside Docker.

refs #2930

Revision f7189971 (diff)
Added by Ward Vandewege almost 3 years ago

Jenkins doesn't have an interactive shell.

refs #2930

Revision 3189de5a (diff)
Added by Ward Vandewege almost 3 years ago

Remove old data.

refs #2930

Revision 8eb5556e (diff)
Added by Ward Vandewege almost 3 years ago

Some more fixes for the docker tests.

refs #2930

Revision 04894ac3 (diff)
Added by Ward Vandewege almost 3 years ago

Remove old code.

refs #2930

Revision 6e18691a (diff)
Added by Ward Vandewege almost 3 years ago

Performance optimization lost in the merge of 2930.

refs #2930

Revision 57da4a65
Added by Ward Vandewege almost 3 years ago

Merge branch '2930-passing-tests' into tapestry-master

refs #2930

Revision 721378eb (diff)
Added by Ward Vandewege almost 3 years ago

Performance optimization lost in the merge of 2930.

refs #2930

History

#1 Updated by Phil Hodgson almost 6 years ago

  • Subject changed from Get rid of deprecation warnings in all tests to Make all tests pass and without deprecation warnings

#2 Updated by Phil Hodgson over 5 years ago

  • Status changed from New to In Progress
  • Start date set to 06/30/2014

#3 Updated by Phil Hodgson over 5 years ago

  • Subject changed from Make all tests pass and without deprecation warnings to Make all tests pass and without deprecation warnings in 1.8.7

#4 Updated by Phil Hodgson over 5 years ago

Annoying deprecation warning on should_allow_values_for and should_not_allow_values_for: we should switch to should allow_value(*values).for(attribute) but if there is more than one value we get a too many arguments error! This must be because of where shoulda is frozen in the Gemfile currently (see commit 89c0d5a02686bbd8b9746ce1849d880a7cd2b0a7). I can't get rid of the deprecation "properly" without separating these calls onto many lines (as I had to for validates_presence_of), and since I believe the problem will disappear after we upgrade Ruby and the shoulda gem, I'm going to leave these in and fix them when Ruby and shoulda gets upgraded. As long as there aren't too many exceptions like this, we should be able to keep things under control.

#5 Updated by Phil Hodgson over 5 years ago

There are a series of tests related to User#in_screening_eligibility_group but it seems as if Tapestry grew out of using such groupings. There is no longer this method in the User model. However, there seem to be a residual controller and a lot of "waitlist" logic in the code base, and it's not yet clear to me whether all of this has been abandoned and should be removed entirely (which would help clean things up a bit, to be sure!), or whether this code should be maintained in the event that similar Enrollment Steps and conditions will be applicable again in the future.

In the meantime I am going to at least remove the in_screening_eligibility_group tests, since it can't make sense to test a method that was removed.

#6 Updated by Phil Hodgson over 5 years ago

  • Status changed from In Progress to Resolved
  • Remaining (hours) set to 0.0

Also available in: Atom PDF